From: David Miller <davem@davemloft.net>
To: jmorris@namei.org
Cc: tonyb@cybernetics.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fix kernel_accept() error path
Date: Thu, 04 Oct 2007 15:08:37 -0700 (PDT) [thread overview]
Message-ID: <20071004.150837.102125151.davem@davemloft.net> (raw)
In-Reply-To: <Xine.LNX.4.64.0710041456300.13076@us.intercode.com.au>
From: James Morris <jmorris@namei.org>
Date: Thu, 4 Oct 2007 14:57:33 -0700 (PDT)
> On Thu, 4 Oct 2007, Tony Battersby wrote:
>
> > If accept() returns an error, kernel_accept() releases the new socket
> > but passes a pointer to the released socket back to the caller. Make it
> > pass back NULL instead.
> >
> > Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> > ---
> > --- linux-2.6.23-rc9/net/socket.c.bak 2007-10-04 15:21:17.000000000 -0400
> > +++ linux-2.6.23-rc9/net/socket.c 2007-10-04 15:21:22.000000000 -0400
> > @@ -2230,6 +2230,7 @@ int kernel_accept(struct socket *sock, s
> > err = sock->ops->accept(sock, *newsock, flags);
> > if (err < 0) {
> > sock_release(*newsock);
> > + *newsock = NULL;
> > goto done;
> > }
> >
>
> If you get an error back from kernel_accept, you should not be trying to
> use newsock.
Agreed, the caller should not try to deref the thing, it's
value is undefined.
next prev parent reply other threads:[~2007-10-04 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 20:20 [PATCH] net: fix kernel_accept() error path Tony Battersby
2007-10-04 21:57 ` James Morris
2007-10-04 22:08 ` David Miller [this message]
2007-10-04 22:12 ` Tony Battersby
2007-10-04 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004.150837.102125151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).