From: Michael Wu <flamingice@sourmilk.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>, Daniel Drake <dsd@gentoo.org>,
johannes@sipsolutions.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed
Date: Thu, 4 Oct 2007 13:11:33 -0400 [thread overview]
Message-ID: <200710041311.37997.flamingice@sourmilk.net> (raw)
In-Reply-To: <20071004151956.GE6037@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Thursday 04 October 2007 11:19, John W. Linville wrote:
> > The reason why BUG_ON exists is to catch bugs that happen, although
> > they Should Never Happen (tm) ;)
>
> Precisely.
No really, this bug will never happen. This is function is merely a helper
function which is called from interface removal code (where the interface
*has* to be down) or from changing the interface type (which ensures that the
interface is down first). There are an unlimited number of bugs which Should
Never Happen. That doesn't mean we should start adding BUG_ONs for every
single one of them. That gives some sort of protection against cosmic rays
flipping bits, but down here on earth, it's bloat.
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-04 17:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 11:33 [PATCH] mac80211: Fix TX after monitor interface is converted to managed Daniel Drake
2007-10-04 14:34 ` Michael Wu
2007-10-04 15:06 ` Michael Buesch
[not found] ` <200710041706.06182.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-10-04 15:14 ` Michael Wu
2007-10-04 15:19 ` John W. Linville
2007-10-04 17:11 ` Michael Wu [this message]
2007-10-04 18:15 ` John W. Linville
2007-10-04 21:16 ` Michael Wu
2007-10-04 21:31 ` Roland Dreier
2007-10-04 22:13 ` John W. Linville
2007-10-04 18:12 ` Johannes Berg
2007-10-04 15:54 ` Stephen Hemminger
[not found] ` <20071004085440.008216c6-s08KbqtN0aBORcJjwVk881hTQxXnIo14@public.gmane.org>
2007-10-04 16:56 ` Michael Wu
2007-10-04 18:07 ` John W. Linville
2007-10-04 18:09 ` [PATCH] ieee80211_if_set_type: make check for master dev more explicit John W. Linville
2007-10-04 18:44 ` Johannes Berg
[not found] ` <1191523488.7367.16.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-10-04 19:13 ` John W. Linville
[not found] ` <20071004191301.GJ6037-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-10-05 12:01 ` Johannes Berg
[not found] ` <20071004180900.GG6037-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-10-04 21:26 ` Michael Wu
[not found] ` <200710041726.11744.flamingice-R9e9/4HEdknk1uMJSBkQmQ@public.gmane.org>
2007-10-04 23:02 ` John W. Linville
[not found] ` <20071004230248.GN6037-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-10-06 2:23 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710041311.37997.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).