From: David Miller <davem@davemloft.net>
To: netdev@axxeo.de
Cc: netdev@vger.kernel.org, Ariel.Hendel@sun.com,
greg.onufer@sun.com, jeff@garzik.org, Ashley.Saulsbury@sun.com,
Matheos.Worku@sun.com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver
Date: Fri, 05 Oct 2007 14:20:01 -0700 (PDT) [thread overview]
Message-ID: <20071005.142001.88714271.davem@davemloft.net> (raw)
In-Reply-To: <200710051846.19965.netdev@axxeo.de>
From: Ingo Oeser <netdev@axxeo.de>
Date: Fri, 5 Oct 2007 18:46:19 +0200
> David Miller schrieb:
> > +#define nr64(reg) readq(np->regs + (reg))
> > +#define nw64(reg, val) writeq((val), np->regs + (reg))
> > +
> > +#define nr64_mac(reg) readq(np->mac_regs + (reg))
> > +#define nw64_mac(reg, val) writeq((val), np->mac_regs + (reg))
> > +
> > +#define nr64_ipp(reg) readq(np->regs + np->ipp_off + (reg))
> > +#define nw64_ipp(reg, val) writeq((val), np->regs + np->ipp_off + (reg))
> > +
> > +#define nr64_pcs(reg) readq(np->regs + np->pcs_off + (reg))
> > +#define nw64_pcs(reg, val) writeq((val), np->regs + np->pcs_off + (reg))
> > +
> > +#define nr64_xpcs(reg) readq(np->regs + np->xpcs_off + (reg))
> > +#define nw64_xpcs(reg, val) writeq((val), np->regs + np->xpcs_off + (reg))
>
> Can these be static inline and get the "struct niu *np" passed?
Absolutely not, this was discussed to death in the first review. This
is a common sequence which is used in several driver, which saves a
lot of typing and carpel-tunnel syndrome.
next prev parent reply other threads:[~2007-10-05 21:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 10:12 [PATCH]: Third (final?) release of Sun Neptune driver David Miller
2007-10-05 15:35 ` Stephen Hemminger
2007-10-05 22:49 ` David Miller
2007-10-05 22:54 ` David Miller
2007-10-05 23:31 ` Jeff Garzik
2007-10-05 22:56 ` David Miller
2007-10-05 23:07 ` David Miller
2007-10-05 23:24 ` David Miller
2007-10-05 23:32 ` Jeff Garzik
2007-10-05 23:27 ` David Miller
2007-10-05 15:39 ` Stephen Hemminger
2007-10-05 21:12 ` David Miller
2007-10-05 21:18 ` Stephen Hemminger
2007-10-05 23:30 ` David Miller
2007-10-05 15:40 ` Stephen Hemminger
2007-10-05 21:12 ` David Miller
2007-10-05 21:14 ` Jeff Garzik
2007-10-05 21:21 ` Stephen Hemminger
2007-10-05 21:40 ` David Miller
2007-10-05 21:38 ` David Miller
2007-10-05 23:42 ` David Miller
2007-10-05 15:43 ` Stephen Hemminger
2007-10-06 0:04 ` David Miller
2007-10-06 0:28 ` Stephen Hemminger
2007-10-06 0:46 ` David Miller
2007-10-06 8:32 ` Johannes Berg
2007-10-05 16:46 ` Ingo Oeser
2007-10-05 16:49 ` Ingo Oeser
2007-10-06 0:08 ` David Miller
2007-10-08 16:04 ` Oliver Hartkopp
2007-10-05 16:55 ` Jeff Garzik
2007-10-05 17:45 ` Matheos Worku
2007-10-05 21:18 ` David Miller
2007-10-05 21:20 ` David Miller [this message]
[not found] ` <470677A0.5060502@sun.com>
2007-10-05 21:24 ` David Miller
2007-10-05 22:18 ` Matheos Worku
2007-10-05 22:43 ` David Miller
2007-10-06 0:10 ` David Miller
2007-10-08 16:01 ` Oliver Hartkopp
2007-10-08 23:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071005.142001.88714271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Hendel@sun.com \
--cc=Ashley.Saulsbury@sun.com \
--cc=Matheos.Worku@sun.com \
--cc=greg.onufer@sun.com \
--cc=jeff@garzik.org \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).