Re: [PATCH]: Third (final?) release of Sun Neptune driver

David Miller
2007-10-05T22:56:48Z

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 5 Oct 2007 08:35:56 -0700

> > +static int __niu_wait_bits_clear(struct niu *np, unsigned long reg,
> > + u64 bits, int limit, int delay)
> > +{
> > + BUILD_BUG_ON(limit <= 0 || delay < 0);
>
> redundant you already checked

Good catch, fixed!

>From 63f926e5b11d3d03815aeb7bd769e8116a3061fb Mon Sep 17 00:00:00 2001
From: David S. Miller <davem@sunset.davemloft.net>
Date: Fri, 5 Oct 2007 15:55:55 -0700
Subject: [PATCH] [NIU]: Remove redundant BUILD_BUG_ON() in __niu_wait_bits_clear().

Noticed by Stephen Hemminger.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/niu.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 92059d7..450d95e 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -192,7 +192,6 @@ static int __niu_set_and_wait_clear_ipp(struct niu *np, unsigned long reg,
static int __niu_wait_bits_clear(struct niu *np, unsigned long reg,
u64 bits, int limit, int delay)
{
- BUILD_BUG_ON(limit <= 0 || delay < 0);
while (--limit >= 0) {
u64 val = nr64(reg);

--
1.5.3.3