Re: [PATCH]: Third (final?) release of Sun Neptune driver

Stephen Hemminger
2007-10-06T00:28:14Z

On Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 5 Oct 2007 08:43:17 -0700
>
> > Sparse warnings from new driver.
> > CHECK drivers/net/niu.c
> > drivers/net/niu.c:619:7: warning: symbol 'err' shadows an earlier one
> > drivers/net/niu.c:574:6: originally declared here
> > drivers/net/niu.c:4673:7: warning: symbol 'err' shadows an earlier one
> > drivers/net/niu.c:4668:12: originally declared here
>
> I fixed these two, the first was harmless but the second
> one would cause error cases to return the wrong error
> status to the caller.
>
> > drivers/net/niu.c:203:2: error: bad constant expression
> > drivers/net/niu.c:203:2: error: cannot size expression
> > drivers/net/niu.c:4214:2: error: bad constant expression
> > drivers/net/niu.c:4214:2: error: cannot size expression
>
> I can't figure out what sparse doesn't like here.

Sparse doesn't like dynamically sized arrays, which is what BUILD_BUG_ON()
expands into. Not sure why it is hostile to dynamic arrays,
probably just a Linus (or Viro) taste thing.