Re: [PATCH]: Third (final?) release of Sun Neptune driver

David Miller
2007-10-05T22:43:36Z

From: Matheos Worku <Matheos.Worku@Sun.COM>
Date: Fri, 05 Oct 2007 15:18:37 -0700

> >
> >> +static void niu_set_max_burst(struct niu *np, struct tx_ring_info *rp)
> >> +{
> >> + int mtu = np->dev->mtu;
> >> +
> >> + rp->max_burst = mtu + 32;
> >> + if (rp->max_burst > 4096)
> >> + rp->max_burst = 4096;
> >
> > Why 32 and 4096? (Magic values)
>
> These values were recommended by the HW designers for fair utilization
> of DRR feature among TX/RX rings.

I'll add macro defines for these, thanks for the feedback.