Re: [PATCH]: Third (final?) release of Sun Neptune driver

David Miller
2007-10-06T00:46:33Z

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 5 Oct 2007 17:28:01 -0700

> On Fri, 05 Oct 2007 17:04:28 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Stephen Hemminger <shemminger@linux-foundation.org>
> > Date: Fri, 5 Oct 2007 08:43:17 -0700
> >
> > > drivers/net/niu.c:203:2: error: bad constant expression
> > > drivers/net/niu.c:203:2: error: cannot size expression
> > > drivers/net/niu.c:4214:2: error: bad constant expression
> > > drivers/net/niu.c:4214:2: error: cannot size expression
> >
> > I can't figure out what sparse doesn't like here.
>
> Sparse doesn't like dynamically sized arrays, which is what BUILD_BUG_ON()
> expands into. Not sure why it is hostile to dynamic arrays,
> probably just a Linus (or Viro) taste thing.

Ok, thanks for tracking it down Stephen.