Re: [PATCH]: Third (final?) release of Sun Neptune driver

Jeff Garzik
2007-10-05T23:32:34Z

David Miller wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 5 Oct 2007 08:35:56 -0700
>
>>> +static void niu_log_rxchan_errors(struct niu *np, struct rx_ring_info *rp,
>>> + u64 stat)
>>> +{
>>> + printk(KERN_ERR PFX "%s: RX channel %u errors ( ",
>>> + np->dev->name, rp->rx_channel);
>> dev_err??
>
> I've made conversions over to dev_err() where possible.
>
> Thanks!
>
>>From cbc4b58382eab08aa231f23d21839c011b4c9f8c Mon Sep 17 00:00:00 2001
> From: David S. Miller <davem@sunset.davemloft.net>
> Date: Fri, 5 Oct 2007 16:22:39 -0700
> Subject: [PATCH] [NIU]: Use dev_err().
>
> Suggested by Stephen Hemminger.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>

It seems you made redundant 1/2 of the comment I just sent :)

ACK