From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jeff@garzik.org, dlunev@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
den@openvz.org
Subject: Re: [NET] IPv6 oops bisected
Date: Sun, 07 Oct 2007 23:23:02 -0700 (PDT) [thread overview]
Message-ID: <20071007.232302.78733656.davem@davemloft.net> (raw)
In-Reply-To: <20071008061942.GA842@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 8 Oct 2007 14:19:42 +0800
> On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote:
> >
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index a7db84c..7109ad6 100644
> > --- a/net/ipv6/route.c
> > +++ b/net/ipv6/route.c
> > @@ -1188,7 +1188,7 @@ int ip6_route_add(struct fib6_config *cfg)
> > if ((cfg->fc_flags & RTF_REJECT) ||
> > (dev && (dev->flags&IFF_LOOPBACK) && !(addr_type&IPV6_ADDR_LOOPBACK))) {
> > /* hold loopback dev/idev if we haven't done so. */
> > - if (dev != dev->nd_net->loopback_dev) {
> > + if (!dev || (dev != dev->nd_net->loopback_dev)) {
> > if (dev) {
> > dev_put(dev);
> > in6_dev_put(idev);
>
> Unfortunately this'll still oops a few lines down when it tries
> to assign dev->nd_net->loopabck_dev to dev. The issue here is
> which namespace are we in if dev is NULL.
Good catch.
I'm just going to revert my bogus fix and the original change
for now. Denis can resubmit the original patch once this
is resolved.
next prev parent reply other threads:[~2007-10-08 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 12:52 [NET] IPv6 oops bisected Jeff Garzik
2007-10-07 13:33 ` Jeff Garzik
2007-10-07 13:49 ` Denis V. Lunev
2007-10-07 14:56 ` Jeff Garzik
2007-10-08 6:16 ` David Miller
2007-10-08 6:19 ` Herbert Xu
2007-10-08 6:23 ` David Miller [this message]
2007-10-08 6:34 ` Denis V. Lunev
2007-10-08 6:46 ` David Miller
2007-10-08 7:00 ` Denis V. Lunev
2007-10-08 16:02 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007.232302.78733656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=den@openvz.org \
--cc=dlunev@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).