From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: mchan@broadcom.com, mcarlson@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH][TG3]Some cleanups
Date: Sun, 07 Oct 2007 23:32:35 -0700 (PDT) [thread overview]
Message-ID: <20071007.233235.115620499.davem@davemloft.net> (raw)
In-Reply-To: <1191769941.4394.1.camel@localhost>
From: jamal <hadi@cyberus.ca>
Date: Sun, 07 Oct 2007 11:12:21 -0400
> Ok, attached patch against net-2.6.24 from this morning. I am setting up
> some equipment for testing as i type this - so i will test for any
> regressions. If you dont hear from me on the subject then all went ok.
This "cleanup" only makes sense if we go with your TX batching
interfaces.
They make the TX batching support patch for this driver "nice" and
"clean", but it makes zero sense in any other context. In fact, it
adds more memory references in the TX pacth, and in fact does so by
adding usage of the skb->cb[] which the driver didn't need to do
previously.
So I'm going to hold off on this one for now, keep it in your TX
batching changes instead.
THanks.
next prev parent reply other threads:[~2007-10-08 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 18:11 [PATCH][TG3]Some cleanups jamal
2007-09-30 18:12 ` jamal
2007-10-02 0:21 ` Michael Chan
2007-10-02 12:37 ` jamal
2007-10-02 23:33 ` Michael Chan
2007-10-03 13:18 ` jamal
2007-10-07 15:12 ` jamal
2007-10-08 6:32 ` David Miller [this message]
2007-10-08 13:42 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007.233235.115620499.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).