From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6.24] net: sparse warning fixes
Date: Sun, 07 Oct 2007 23:59:56 -0700 (PDT) [thread overview]
Message-ID: <20071007.235956.98531097.davem@davemloft.net> (raw)
In-Reply-To: <20071005171407.19c65258@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 5 Oct 2007 17:14:07 -0700
> Fix a bunch of sparse warnings. Mostly about 0 used as
> NULL pointer, and shadowed variable declarations.
>
> The two noteable changes are:
> * hash size should have been unsigned
> * cls_u32 had a case where error code wasn't been
> propogated properly, so it could return 0 but still
> have an error.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied, and I stuffed the cls_u32 fix into net-2.6 as well.
But please fix the following, this is the second time I've
had to remove this bit from one of your patches.
> @@ -6,7 +6,7 @@
> *
> * Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> * Ben Greear <greearb@candelatech.com>
> - * Jens Låås <jens.laas@data.slu.se>
> + * Jens Låås <jens.laas@data.slu.se>
> *
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License
Please please please please, for the second time, fix the encoding
your editor uses when you save copies of this source file, this hunk
of your patches never applies cleanly.
Thanks.
next prev parent reply other threads:[~2007-10-08 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 3:10 [PATCH net-2.6.24] fix network compile warnings Stephen Hemminger
2007-10-06 0:14 ` [PATCH net-2.6.24] net: sparse warning fixes Stephen Hemminger
2007-10-08 6:59 ` David Miller [this message]
2007-10-08 15:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071007.235956.98531097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).