From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] net/core: split dev_ifsioc() according to locking
Date: Mon, 08 Oct 2007 00:06:53 -0700 (PDT) [thread overview]
Message-ID: <20071008.000653.51864134.davem@davemloft.net> (raw)
In-Reply-To: <200710070217.09073.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sun, 7 Oct 2007 02:17:08 +0200
> On Saturday 06 October 2007, Jeff Garzik wrote:
> >
> > This always bugged me: dev_ioctl() called dev_ifsioc() either inside
> > read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being
> > executed.
> >
> > This change moves the ioctls executed inside dev_base_lock to a new
> > function, dev_ifsioc_locked(). Now the locking context is completely
> > clear to the reader.
> >
> > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
>
> Great idea!
I think so too, applied, thanks!
prev parent reply other threads:[~2007-10-08 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 20:42 [PATCH] net/core: split dev_ifsioc() according to locking Jeff Garzik
2007-10-07 0:17 ` Arnd Bergmann
2007-10-08 7:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008.000653.51864134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).