Re: [PATCH 1/8][BNX2X] resubmit as attachments: add bnx2x to Kconfig and Makefile

[David Miller <davem@davemloft.net>]

From: "Eliezer Tamir" <eliezert@broadcom.com>
Date: Mon, 08 Oct 2007 18:15:17 +0200

> Add bnx2x to Kconfig and Makefile

In a patch submission, the tree should build on every step along the
way in applying your patches, with any given configuration.

Here, the user (or something automated like "make allmodconfig") can
select the new config option, but because the driver source hasn't
been added, the compile will fail.

The idea is that if your patch set really is composed of logically
seperate changes, you submit them one logical compilable piece at a
time, and if the first few patches are ok, they could go right in
whilst we work out issues in later patches.  But that's not how
a new driver is, it is logically one change only.

You go on next to add a foo.c file, and then a foo.h file.
This makes things even more difficult to review.

Really, for a new driver that doesn't make any generic kernel code
changes, just submit the whole thing in one shot.  It's the only
reasonable way.

Thank you.