netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: ebiederm@xmission.com, netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2)
Date: Mon, 08 Oct 2007 20:38:57 -0700 (PDT)	[thread overview]
Message-ID: <20071008.203857.92246440.davem@davemloft.net> (raw)
In-Reply-To: <470A2E81.5050006@openvz.org>

From: Pavel Emelyanov <xemul@openvz.org>
Date: Mon, 08 Oct 2007 17:20:01 +0400

> With the net namespaces many code leaved the __init section,
> thus making the kernel occupy more memory than it did before.
> Since we have a config option that prohibits the namespace
> creation, the functions that initialize/finalize some netns
> stuff are simply not needed and can be freed after the boot.
> 
> Currently, this is almost not noticeable, since few calls
> are no longer in __init, but when the namespaces will be
> merged it will be possible to free more code. I propose to 
> use the __net_init, __net_exit and __net_initdata "attributes"
> for functions/variables that are not used if the CONFIG_NET_NS
> is not set to save more space in memory.
> 
> The exiting functions cannot just reside in the __exit section,
> as noticed by David, since the init section will have 
> references on it and the compilation will fail due to modpost 
> checks. These references can exist, since the init namespace 
> never dies and the exit callbacks are never called. So I 
> introduce the __exit_refok attribute just like it is already 
> done with the __init_refok.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied, thanks for fixing this up Pavel.

      reply	other threads:[~2007-10-09  3:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 13:20 [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2) Pavel Emelyanov
2007-10-09  3:38 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071008.203857.92246440.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).