From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Karsten Keil <kkeil@suse.de>
Cc: isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org
Subject: Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN
Date: Mon, 8 Oct 2007 10:39:02 -0700 [thread overview]
Message-ID: <20071008103902.1fc6ff7c@freepuppy.rosehill> (raw)
In-Reply-To: <20071008114844.GB11453@pingi.kke.suse.de>
On Mon, 8 Oct 2007 13:48:44 +0200
Karsten Keil <kkeil@suse.de> wrote:
> On Sun, Oct 07, 2007 at 02:06:53PM +0200, Andreas Mohr wrote:
> > [not necessarily a very recent regression, used 2.6.19 kernels before...]
> >
> > Hi all,
> >
> > wondered why my main internet server (headless!) didn't come up properly
> > on a new 2.6.23-rc8-mm2
> ...
> > as if it's the
> > BUG_ON(!dev->nd_net);
> > check which caused the BUG message.
>
> The regression comes from the net namespace patches.
> Up to now in ISDN the struct netdevice is contained in struct isdn_net_dev and so
> it's not allocated using alloc_netdev(), which would set the missing dev->nd_net
> pointer.
>
>
Then ISDN is BROKEN in existing code. ALL network devices must be allocated
by alloc_netdev() not the device driver otherwise there is no way to prevent
oopsing through sysfs. RTFM Documentation/networking/netdevices.txt
Please fix for 2.6.23 and 2.6.22 stable.
--
Stephen Hemminger <shemminger@linux-foundation.org>
prev parent reply other threads:[~2007-10-08 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 12:06 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN Andreas Mohr
2007-10-07 12:24 ` Jeff Garzik
2007-10-07 13:17 ` Andreas Mohr
2007-10-07 17:20 ` Andreas Mohr
2007-10-08 15:58 ` Karsten Keil
2007-10-09 3:37 ` David Miller
2007-10-12 14:05 ` Karsten Keil
2007-10-15 9:12 ` David Miller
2007-10-09 19:06 ` Andreas Mohr
2007-10-08 11:48 ` Karsten Keil
2007-10-08 17:39 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071008103902.1fc6ff7c@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).