From: David Miller <davem@davemloft.net>
To: aarapov@redhat.com
Cc: den@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH] division-by-zero in inet_csk_get_port
Date: Wed, 10 Oct 2007 02:35:15 -0700 (PDT) [thread overview]
Message-ID: <20071010.023515.15263796.davem@davemloft.net> (raw)
In-Reply-To: <m31wc3l4ym.fsf@bandura.englab.brq.redhat.com>
From: Anton Arapov <aarapov@redhat.com>
Date: Wed, 10 Oct 2007 11:00:17 +0200
> Ok, I've got it, so we have to do the same with the following:
> quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
> patch.
>
> And just a curious, does the /* Treat low > high as high == low */
> idea will keep after the sysctl will be patched?
I'm beginning to think that we should do the sysctl validation
in this patch too, instead of duplicating this grotty check
in all of these port selection functions.
next prev parent reply other threads:[~2007-10-10 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 8:55 [PATCH] division-by-zero in inet_csk_get_port Denis V. Lunev
2007-10-10 9:00 ` Anton Arapov
2007-10-10 9:35 ` David Miller [this message]
2007-10-10 9:56 ` Anton Arapov
2007-10-10 10:01 ` David Miller
2007-10-10 12:49 ` Anton Arapov
2007-10-10 15:04 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010.023515.15263796.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aarapov@redhat.com \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).