netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mitch@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
	herbert@gondor.apana.org.au
Subject: Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified
Date: Wed, 10 Oct 2007 02:53:07 -0700 (PDT)	[thread overview]
Message-ID: <20071010.025307.68156581.davem@davemloft.net> (raw)
In-Reply-To: <20071009162158.f25d4fdb.mitch@linux.vnet.ibm.com>

From: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Date: Tue, 9 Oct 2007 16:21:58 +0900

> To judge the timing for DAD, netif_carrier_ok() is used. However,
> there is a possibility that dev->qdisc stays noop_qdisc even if
> netif_carrier_ok() returns true. In that case, DAD NS is not sent out.
> We need to defer the IPv6 device initialization until a valid qdisc
> is specified.
> 
> Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

Thanks for submitting the fix.

Although Herbert is right that this does not fix the problem
universally, it does make things better, so I will apply this
patch.

Thanks!

      parent reply	other threads:[~2007-10-10  9:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09  7:21 [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified Mitsuru Chinen
2007-10-10  1:32 ` Herbert Xu
2007-10-10  3:16   ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-10  3:27     ` Herbert Xu
2007-10-10  9:53 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010.025307.68156581.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=mitch@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).