From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: den@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH] do not give access to 1-1024 ports for autobinding
Date: Wed, 10 Oct 2007 15:51:51 -0700 (PDT) [thread overview]
Message-ID: <20071010.155151.11054291.davem@davemloft.net> (raw)
In-Reply-To: <20071010084137.1963122e@freepuppy.rosehill>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 10 Oct 2007 08:41:37 -0700
> On Wed, 10 Oct 2007 18:34:49 +0400
> "Denis V. Lunev" <den@openvz.org> wrote:
>
> > This patch prevents possibility to give 1-1024 port range for autobinding.
> > {1, 1} may only takes some sense for deep embedded people.
> >
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> >
> > --- ./net/ipv4/sysctl_net_ipv4.c.port2 2007-10-10 17:46:48.000000000 +0400
> > +++ ./net/ipv4/sysctl_net_ipv4.c 2007-10-10 18:08:00.000000000 +0400
> > @@ -25,7 +25,7 @@ extern int sysctl_ip_nonlocal_bind;
> > #ifdef CONFIG_SYSCTL
> > static int zero;
> > static int tcp_retr1_max = 255;
> > -static int ip_local_port_range_min[] = { 1, 1 };
> > +static int ip_local_port_range_min[] = { 1024, 1024 };
> > static int ip_local_port_range_max[] = { 65535, 65535 };
> > #endif
> >
> > -
>
> That only limits the sysctl, which seems completely counter productive.
> Sounds like more of the "stop root from shooting themselves" patches.
Agreed, we shouldn't be changing these values.
next prev parent reply other threads:[~2007-10-10 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 14:34 [PATCH] do not give access to 1-1024 ports for autobinding Denis V. Lunev
2007-10-10 15:41 ` Stephen Hemminger
2007-10-10 16:59 ` Denis V. Lunev
2007-10-10 17:12 ` Stephen Hemminger
2007-10-10 22:55 ` David Miller
2007-10-10 22:51 ` David Miller [this message]
2007-10-10 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010.155151.11054291.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).