From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Denis V. Lunev" <dlunev@gmail.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] do not give access to 1-1024 ports for autobinding
Date: Wed, 10 Oct 2007 10:12:03 -0700 [thread overview]
Message-ID: <20071010101203.0e3da7ab@freepuppy.rosehill> (raw)
In-Reply-To: <470D04E1.9030505@gmail.com>
On Wed, 10 Oct 2007 20:59:13 +0400
"Denis V. Lunev" <dlunev@gmail.com> wrote:
> Stephen Hemminger wrote:
> > On Wed, 10 Oct 2007 18:34:49 +0400
> > "Denis V. Lunev" <den@openvz.org> wrote:
> >
> >> This patch prevents possibility to give 1-1024 port range for autobinding.
> >> {1, 1} may only takes some sense for deep embedded people.
> >>
> >> Signed-off-by: Denis V. Lunev <den@openvz.org>
> >>
> >> --- ./net/ipv4/sysctl_net_ipv4.c.port2 2007-10-10 17:46:48.000000000 +0400
> >> +++ ./net/ipv4/sysctl_net_ipv4.c 2007-10-10 18:08:00.000000000 +0400
> >> @@ -25,7 +25,7 @@ extern int sysctl_ip_nonlocal_bind;
> >> #ifdef CONFIG_SYSCTL
> >> static int zero;
> >> static int tcp_retr1_max = 255;
> >> -static int ip_local_port_range_min[] = { 1, 1 };
> >> +static int ip_local_port_range_min[] = { 1024, 1024 };
> >> static int ip_local_port_range_max[] = { 65535, 65535 };
> >> #endif
> >>
> >> -
> >
> > That only limits the sysctl, which seems completely counter productive.
> > Sounds like more of the "stop root from shooting themselves" patches.
> >
>
> They have sense for the case of multiple network namespaces, where root
> in the other namespace can be treated as a user to initial namespace.
IMHO don't want to treat root as a complete idiot like normal users.
As long as what root requests doesn't create a security problem, it
should be allowed. The port space is per namespace right? The sysctl
values should be per namespace as well.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-10 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 14:34 [PATCH] do not give access to 1-1024 ports for autobinding Denis V. Lunev
2007-10-10 15:41 ` Stephen Hemminger
2007-10-10 16:59 ` Denis V. Lunev
2007-10-10 17:12 ` Stephen Hemminger [this message]
2007-10-10 22:55 ` David Miller
2007-10-10 22:51 ` David Miller
2007-10-10 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010101203.0e3da7ab@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=dlunev@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox