From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
Cc: Andi Kleen <andi@firstfloor.org>,
David Miller <davem@davemloft.net>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev <netdev@vger.kernel.org>, ?? ?? <yoshfuji@linux-ipv6.org>,
Yumiko SUGITA <yumiko.sugita.yf@hitachi.com>,
"??@RedHat" <haoki@redhat.com>
Subject: Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation
Date: Thu, 11 Oct 2007 12:46:56 -0700 [thread overview]
Message-ID: <20071011124656.01dd575b@freepuppy.rosehill> (raw)
In-Reply-To: <470E1C42.1050901@hitachi.com>
On Thu, 11 Oct 2007 21:51:14 +0900
Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com> wrote:
> Hi Stephen,
>
> Thank you for your comment.
>
> >> {
> >> + .ctl_name = NET_UDP_MEM,
> >> + .procname = "udp_mem",
> >> + .data = &sysctl_udp_mem,
> >> + .maxlen = sizeof(sysctl_udp_mem),
> >> + .mode = 0644,
> >> + .proc_handler = &proc_dointvec
> >> + },
> >> + {
> >> .ctl_name = NET_TCP_APP_WIN,
> >> .procname = "tcp_app_win",
> >> .data = &sysctl_tcp_app_win,
> >
> > if you use &proc_dointvec_minmax, then you could inforce min/max
> > values for udp_mem for the sysctl
One other comment. Sysctl value indexes are deprecated at this point
so all new values should use CTL_UNNUMBERED. Therefore unless NET_UDP_MEM
already exists, please don't add it.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-11 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 14:59 [RFC/PATCH 0/4]UDP memory accounting (take 4) Satoshi OSHIMA
2007-10-05 15:00 ` [RFC/PATCH 1/4] UDP memory usage accounting (take 4): fix send buffer check Satoshi OSHIMA
2007-10-05 15:01 ` [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable Satoshi OSHIMA
2007-10-07 10:09 ` Evgeniy Polyakov
2007-10-10 8:14 ` Satoshi OSHIMA
2007-10-05 15:02 ` [RFC/PATCH 3/4] UDP memory usage accounting (take 4): memory usage accounting Satoshi OSHIMA
2007-10-05 15:02 ` [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation Satoshi OSHIMA
2007-10-05 15:52 ` Stephen Hemminger
2007-10-11 12:51 ` Satoshi OSHIMA
2007-10-11 19:46 ` Stephen Hemminger [this message]
2007-10-12 11:58 ` Satoshi OSHIMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011124656.01dd575b@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=haoki@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox