From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: takano@axe-inc.co.jp, netdev@vger.kernel.org,
ilpo.jarvinen@helsinki.fi, mchan@broadcom.com
Subject: Re: Regression in net-2.6.24?
Date: Thu, 11 Oct 2007 18:22:59 -0700 [thread overview]
Message-ID: <20071011182259.3715182d@freepuppy.rosehill> (raw)
In-Reply-To: <20071011.181449.130846976.davem@davemloft.net>
On Thu, 11 Oct 2007 18:14:49 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
>
> Here is what I'm checking into net-2.6 for now:
>
> commit 6f535763165331bb91277d7519b507fed22034e5
> Author: David S. Miller <davem@sunset.davemloft.net>
> Date: Thu Oct 11 18:08:29 2007 -0700
>
> [NET]: Fix NAPI completion handling in some drivers.
>
> In order for the list handling in net_rx_action() to be
> correct, drivers must follow certain rules as stated by
> this comment in net_rx_action():
>
> /* Drivers must not modify the NAPI state if they
> * consume the entire weight. In such cases this code
> * still "owns" the NAPI instance and therefore can
> * move the instance around on the list at-will.
> */
>
> A few drivers do not do this because they mix the budget checks
> with reading hardware state, resulting in crashes like the one
> reported by takano@axe-inc.co.jp.
>
> BNX2 and TG3 are taken care of here, SKY2 fix is from Stephen
> Hemminger.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
Please use the version I just sent, it saves another non-cached read.
next prev parent reply other threads:[~2007-10-12 1:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 12:19 [RFC PATCH net-2.6.24 0/3]: Attempt to fix lost_retrans brokeness Ilpo Järvinen
2007-10-09 12:20 ` [PATCH] [TCP]: Separate lost_retrans loop into own function Ilpo Järvinen
2007-10-09 12:20 ` [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems Ilpo Järvinen
2007-10-09 12:20 ` [RFC PATCH] [TCP]: Limit processing lost_retrans loop to work-to-do cases Ilpo Järvinen
2007-10-10 9:44 ` David Miller
2007-10-10 9:44 ` David Miller
2007-10-11 1:55 ` [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems TAKANO Ryousei
2007-10-11 10:12 ` Ilpo Järvinen
2007-10-11 13:51 ` Regression in net-2.6.24? TAKANO Ryousei
2007-10-11 23:48 ` David Miller
2007-10-11 23:55 ` Stephen Hemminger
2007-10-12 0:17 ` David Miller
2007-10-12 0:31 ` Stephen Hemminger
2007-10-12 0:40 ` David Miller
2007-10-12 0:50 ` Stephen Hemminger
2007-10-12 1:00 ` David Miller
2007-10-12 1:03 ` David Miller
2007-10-12 1:14 ` David Miller
2007-10-12 1:22 ` Stephen Hemminger [this message]
2007-10-12 1:25 ` David Miller
2007-10-12 3:17 ` Michael Chan
2007-10-12 2:40 ` David Miller
2007-10-12 8:54 ` Michael Chan
2007-10-12 8:39 ` David Miller
2007-10-12 10:22 ` TAKANO Ryousei
2007-10-12 10:56 ` David Miller
2007-10-10 9:45 ` [PATCH] [TCP]: Separate lost_retrans loop into own function David Miller
2007-10-09 13:03 ` [RFC PATCH net-2.6.24 0/3]: Attempt to fix lost_retrans brokeness Ilpo Järvinen
2007-10-10 9:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011182259.3715182d@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=takano@axe-inc.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox