From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: netdev@vger.kernel.org, Norbert Buchmuller <norbi@nix.hu>,
Andreas Henriksson <andreas@fatal.se>
Subject: Re: [PATCH 10/12] Fix off-by-one in print of wrandom algo.
Date: Fri, 12 Oct 2007 14:39:10 -0700 [thread overview]
Message-ID: <20071012143910.4e6050bf@freepuppy.rosehill> (raw)
In-Reply-To: <1192179407-22461-10-git-send-email-andreas@fatal.se>
On Fri, 12 Oct 2007 10:56:45 +0200
Andreas Henriksson <andreas@fatal.se> wrote:
> From: Norbert Buchmuller <norbi@nix.hu>
>
> The 'wrandom' multipath algo is recognised when adding the route, but
> not resolved when it is printed (prints 'unknown'):
>
> ianus:~# ip ro add 1.2.3.4 mpath wrandom nexthop dev ppp0 weight 1 nexthop dev ppp1 weight 2
> ianus:~# ip ro get to 1.2.3.4
> 1.2.3.4 mpath unknown dev ppp0 src 62.77.192.67
> cache mtu 1492 advmss 1452 hoplimit 64
> ianus:~# ip ro del 1.2.3.4 mpath wrandom nexthop dev ppp0 weight 1 nexthop dev ppp1 weight 2
>
> See http://bugs.debian.org/428440 for more information.
>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
> ---
> ip/iproute.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index d3a3243..3b5c4b1 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -365,7 +365,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
> __u32 mp_alg = *(__u32*) RTA_DATA(tb[RTA_MP_ALGO]);
> if (mp_alg > IP_MP_ALG_NONE) {
> fprintf(fp, "mpath %s ",
> - mp_alg < IP_MP_ALG_MAX ? mp_alg_names[mp_alg] : "unknown");
> + mp_alg <= IP_MP_ALG_MAX ? mp_alg_names[mp_alg] : "unknown");
> }
> }
>
Actually since multi-path was removed from kernel, I just pulled support
for it from current iproute
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-12 21:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 8:56 [PATCH 01/12] Fix various typos and nitpicks Andreas Henriksson
2007-10-12 8:56 ` [PATCH 02/12] Add parameters to usage help text Andreas Henriksson
2007-10-12 8:56 ` [PATCH 03/12] Prevent renaming interfaces to empty string Andreas Henriksson
2007-10-12 8:56 ` [PATCH 04/12] Fix up various problems in netbug script Andreas Henriksson
2007-10-12 8:56 ` [PATCH 05/12] Fix typo in tunnel code (o_key vs. i_key) Andreas Henriksson
2007-10-12 8:56 ` [PATCH 06/12] Remove bogus reference to tc-filters(8) from tc(8) manpage Andreas Henriksson
2007-10-12 8:56 ` [PATCH 07/12] Fix corruption when using batch files with comments and broken lines Andreas Henriksson
2007-10-12 8:56 ` [PATCH 08/12] Fix ematch cmp and nbyte syntax help text Andreas Henriksson
2007-10-12 8:56 ` [PATCH 09/12] Add new rtacct/nstat manpages and additional symlinks Andreas Henriksson
2007-10-12 8:56 ` [PATCH 10/12] Fix off-by-one in print of wrandom algo Andreas Henriksson
2007-10-12 8:56 ` [PATCH 11/12] Fix overflow in time2tick / tick2time Andreas Henriksson
2007-10-12 8:56 ` [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage Andreas Henriksson
2007-10-12 21:50 ` Stephen Hemminger
2007-10-12 22:49 ` Patrick McHardy
2007-10-17 16:50 ` Andreas Henriksson
2007-10-17 17:05 ` Stephen Hemminger
2007-10-17 17:58 ` Andreas Henriksson
2007-10-17 18:02 ` Stephen Hemminger
2007-10-18 8:13 ` Andreas Henriksson
2007-10-12 21:39 ` Stephen Hemminger [this message]
2007-10-12 17:14 ` [PATCH 04/12] Fix up various problems in netbug script Stephen Hemminger
2007-10-12 17:39 ` Andreas Henriksson
2007-10-12 12:01 ` [PATCH 03/12] Prevent renaming interfaces to empty string Patrick McHardy
2007-10-12 17:07 ` Stephen Hemminger
2007-10-12 17:45 ` Andreas Henriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012143910.4e6050bf@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
--cc=norbi@nix.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).