From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: guichaz@yahoo.fr, netdev@vger.kernel.org
Subject: Re: [NET]: Fix csum_start update in pskb_expand_head
Date: Mon, 15 Oct 2007 01:46:34 -0700 (PDT) [thread overview]
Message-ID: <20071015.014634.58769774.davem@davemloft.net> (raw)
In-Reply-To: <20071015045723.GA28388@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 15 Oct 2007 12:57:23 +0800
> On Sun, Oct 14, 2007 at 08:20:37PM +0000, Guillaume Chazarain wrote:
> >
> > Just another data point, it seems that running the standard Bittorrent
> > client helps triggering the bug.
>
> Doh! It was my patch a month ago which added code to update
> csum_start if the headroom changed that broke this.
>
> We'll need this patch for stable as well.
>
> [NET]: Fix csum_start update in pskb_expand_head
>
> I got confused by the dual nature of the off variable in the
> function pskb_expand_head. The csum_start offset should use
> nhead instead of off which can change depending on whether we
> are using offsets or pointers.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied and I'll take care of the -stable submission.
next prev parent reply other threads:[~2007-10-15 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 12:15 kernel BUG at net/core/dev.c:1383 skb_checksum_help: BUG_ON(offset > (int)skb->len) Guillaume Chazarain
2007-10-14 17:26 ` Guillaume Chazarain
2007-10-14 20:20 ` Guillaume Chazarain
2007-10-15 4:57 ` [NET]: Fix csum_start update in pskb_expand_head Herbert Xu
2007-10-15 5:54 ` [NET]: Avoid copying TCP packets unnecessarily Herbert Xu
2007-10-15 8:47 ` David Miller
2007-10-15 8:46 ` David Miller [this message]
2007-10-15 9:21 ` [NET]: Fix csum_start update in pskb_expand_head Guillaume Chazarain
2007-10-15 10:08 ` kernel BUG at net/core/dev.c:1383 skb_checksum_help: BUG_ON(offset > (int)skb->len) Ilpo Järvinen
2007-10-15 10:15 ` Ilpo Järvinen
2007-10-15 10:18 ` Guillaume Chazarain
2007-10-15 10:54 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015.014634.58769774.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=guichaz@yahoo.fr \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).