From: David Miller <davem@davemloft.net>
To: eliezert@broadcom.com
Cc: andi@firstfloor.org, netdev@vger.kernel.org, jeff@garzik.org,
mchan@broadcom.com
Subject: Re: [PATCH][BNX2X] round three
Date: Mon, 15 Oct 2007 12:38:50 -0700 (PDT) [thread overview]
Message-ID: <20071015.123850.26516814.davem@davemloft.net> (raw)
In-Reply-To: <1192462049.29746.158.camel@eliezer>
From: "Eliezer Tamir" <eliezert@broadcom.com>
Date: Mon, 15 Oct 2007 17:27:29 +0200
> Unfortunately, the firmware code is different for LE and BE machines.
> We had issues with the BE firmware that appear to be resolved.
> Hopefully, the next version will have both.
If this means we get two copies of the firmware, this should be
rethought. The space cost of the firmware (both in terms of source
code size and object code size) is already enormous.
I would definitely prefer if there were only little-endian firmware,
and the driver uses "cpu_to_le32()" and friends to access chip shared
data structures.
Most cpus have endian swapping loads and stores, accessible via
cpu_to_le32p() and similar interfaces, so the cost on big-endian of
doing things this way is very close to zero.
next prev parent reply other threads:[~2007-10-15 19:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 17:49 [PATCH][BNX2X] round three Eliezer Tamir
2007-10-10 19:52 ` Eliezer Tamir
2007-10-11 0:59 ` David Miller
2007-10-11 17:53 ` Eliezer Tamir
2007-10-11 21:40 ` David Miller
2007-10-11 1:28 ` Stephen Hemminger
2007-10-11 17:13 ` Eliezer Tamir
2007-10-11 1:54 ` [PATCH][BNX2X] round three - sparse warnings Stephen Hemminger
2007-10-11 17:21 ` Eliezer Tamir
2007-10-12 14:47 ` [PATCH][BNX2X] round three Andi Kleen
2007-10-12 22:03 ` David Miller
2007-10-15 15:27 ` Eliezer Tamir
2007-10-15 16:05 ` Andi Kleen
2007-10-15 16:22 ` Eliezer Tamir
2007-10-15 16:24 ` Andi Kleen
2007-10-15 19:42 ` David Miller
2007-10-15 19:38 ` David Miller [this message]
2007-10-15 21:58 ` Stephen Hemminger
2007-10-15 22:00 ` David Miller
2007-10-15 22:06 ` Stephen Hemminger
2007-10-16 15:00 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015.123850.26516814.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andi@firstfloor.org \
--cc=eliezert@broadcom.com \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).