[PATCH] [TCP]: Make snd_cwnd_cnt 32-bit

[PATCH] [TCP]: Make snd_cwnd_cnt 32-bit

[Ilpo Järvinen]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 976 bytes --]


Very little point of having 32-bit snd_cnwd if this is not
32-bit as well, as a number of snd_cwnd incrementation formulas
assume that snd_cwnd_cnt can be at least as large as snd_cwnd.

Whether 32-bit is useful was discussed when e0ef57cc56c3c96
was made:
  http://marc.info/?l=linux-netdev&m=117218144409825&w=2

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 include/linux/tcp.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index c5b94c1..997b349 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
@@ -315,7 +315,7 @@ struct tcp_sock {
  */
  	u32	snd_ssthresh;	/* Slow start size threshold		*/
  	u32	snd_cwnd;	/* Sending congestion window		*/
- 	u16	snd_cwnd_cnt;	/* Linear increase counter		*/
+ 	u32	snd_cwnd_cnt;	/* Linear increase counter		*/
 	u32	snd_cwnd_clamp; /* Do not allow snd_cwnd to grow above this */
 	u32	snd_cwnd_used;
 	u32	snd_cwnd_stamp;
-- 
1.5.0.6

k i.

Re: [PATCH] [TCP]: Make snd_cwnd_cnt 32-bit

[David Miller]

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 15 Oct 2007 18:57:31 +0300 (EEST)

> 
> Very little point of having 32-bit snd_cnwd if this is not
> 32-bit as well, as a number of snd_cwnd incrementation formulas
> assume that snd_cwnd_cnt can be at least as large as snd_cwnd.
> 
> Whether 32-bit is useful was discussed when e0ef57cc56c3c96
> was made:
>   http://marc.info/?l=linux-netdev&m=117218144409825&w=2
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Applied, and I intend to push this to -stable as well.

Thanks!