From: David Miller <davem@davemloft.net>
To: cfriesen@nortel.com
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: question on sky2 driver panic
Date: Mon, 15 Oct 2007 22:20:32 -0700 (PDT) [thread overview]
Message-ID: <20071015.222032.78710839.davem@davemloft.net> (raw)
In-Reply-To: <47144920.4010402@nortel.com>
From: "Chris Friesen" <cfriesen@nortel.com>
Date: Mon, 15 Oct 2007 23:16:16 -0600
> Our version of the e1000 passes 200 bytes in the initial chunk, and the
> rest in fragments. tipc currently handles that without any difficulty.
There is no requirement for any bytes to be in the initial skb->data
chunk, in fact the Neptune NIU driver only pulls the ethernet header
into there for example.
net/tipc/eth_media.c:recv_msg() seems to dereference buf->data
directly without making any pskb_may_pull() checks, and that is
a bug.
prev parent reply other threads:[~2007-10-16 5:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 20:17 question on sky2 driver panic Chris Friesen
2007-10-15 22:04 ` Stephen Hemminger
2007-10-16 5:16 ` Chris Friesen
2007-10-16 5:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015.222032.78710839.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cfriesen@nortel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).