From: Andi Kleen <andi@firstfloor.org>
To: Eliezer Tamir <eliezert@broadcom.com>
Cc: Andi Kleen <andi@firstfloor.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, jeff@garzik.org, mchan@broadcom.com
Subject: Re: [PATCH][BNX2X] round three
Date: Mon, 15 Oct 2007 18:24:02 +0200 [thread overview]
Message-ID: <20071015162402.GB15178@one.firstfloor.org> (raw)
In-Reply-To: <1192465323.29746.170.camel@eliezer>
On Mon, Oct 15, 2007 at 06:22:03PM +0200, Eliezer Tamir wrote:
> On Mon, 2007-10-15 at 18:05 +0200, Andi Kleen wrote:
> > > This is not a driver issue.
> > > Unfortunately, the firmware code is different for LE and BE machines.
> > > We had issues with the BE firmware that appear to be resolved.
> > > Hopefully, the next version will have both.
> >
> > If the firmware is big it might be better to just add the necessary
> > conversions to the driver and always use BE. Endian conversions
> > tend to be very cheap.
>
> For a given architecture, only the right version of the microcode is
> compiled, so the binary only contains one copy of the microcode.
But we still have source code bloat. drivers/net already has too much
binary gibberish in hex; no need to add to it unnecessarily.
-Andi
next prev parent reply other threads:[~2007-10-15 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 17:49 [PATCH][BNX2X] round three Eliezer Tamir
2007-10-10 19:52 ` Eliezer Tamir
2007-10-11 0:59 ` David Miller
2007-10-11 17:53 ` Eliezer Tamir
2007-10-11 21:40 ` David Miller
2007-10-11 1:28 ` Stephen Hemminger
2007-10-11 17:13 ` Eliezer Tamir
2007-10-11 1:54 ` [PATCH][BNX2X] round three - sparse warnings Stephen Hemminger
2007-10-11 17:21 ` Eliezer Tamir
2007-10-12 14:47 ` [PATCH][BNX2X] round three Andi Kleen
2007-10-12 22:03 ` David Miller
2007-10-15 15:27 ` Eliezer Tamir
2007-10-15 16:05 ` Andi Kleen
2007-10-15 16:22 ` Eliezer Tamir
2007-10-15 16:24 ` Andi Kleen [this message]
2007-10-15 19:42 ` David Miller
2007-10-15 19:38 ` David Miller
2007-10-15 21:58 ` Stephen Hemminger
2007-10-15 22:00 ` David Miller
2007-10-15 22:06 ` Stephen Hemminger
2007-10-16 15:00 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015162402.GB15178@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=eliezert@broadcom.com \
--cc=jeff@garzik.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).