* [PATCH 1/2] e1000e: Fix debug printk macro
@ 2007-10-15 21:02 Auke Kok
2007-10-15 21:02 ` [PATCH 2/2] e1000e: fix error checks Auke Kok
0 siblings, 1 reply; 3+ messages in thread
From: Auke Kok @ 2007-10-15 21:02 UTC (permalink / raw)
To: jeff; +Cc: netdev, bunk, joe, auke-jan.h.kok
Spotted by Joe Perches.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000e/hw.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h
index aa82f1a..6451578 100644
--- a/drivers/net/e1000e/hw.h
+++ b/drivers/net/e1000e/hw.h
@@ -852,7 +852,7 @@ struct e1000_hw {
#ifdef DEBUG
#define hw_dbg(hw, format, arg...) \
- printk(KERN_DEBUG, "%s: " format, e1000e_get_hw_dev_name(hw), ##arg);
+ printk(KERN_DEBUG "%s: " format, e1000e_get_hw_dev_name(hw), ##arg)
#else
static inline int __attribute__ ((format (printf, 2, 3)))
hw_dbg(struct e1000_hw *hw, const char *format, ...)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] e1000e: fix error checks
2007-10-15 21:02 [PATCH 1/2] e1000e: Fix debug printk macro Auke Kok
@ 2007-10-15 21:02 ` Auke Kok
2007-10-17 1:15 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Auke Kok @ 2007-10-15 21:02 UTC (permalink / raw)
To: jeff; +Cc: netdev, bunk, joe, auke-jan.h.kok
From: Adrian Bunk <bunk@kernel.org>
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000e/ethtool.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
index b7a7e2a..ca06c35 100644
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter *adapter, u64 *data)
}
*data = e1000_setup_desc_rings(adapter);
- if (data)
+ if (*data)
goto out;
*data = e1000_setup_loopback_test(adapter);
- if (data)
+ if (*data)
goto err_loopback;
*data = e1000_run_loopback_test(adapter);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] e1000e: fix error checks
2007-10-15 21:02 ` [PATCH 2/2] e1000e: fix error checks Auke Kok
@ 2007-10-17 1:15 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-10-17 1:15 UTC (permalink / raw)
To: Auke Kok; +Cc: jeff, netdev, bunk, joe
Auke Kok wrote:
> From: Adrian Bunk <bunk@kernel.org>
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
applied all three patches (1-2, and then the singleton)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-17 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 21:02 [PATCH 1/2] e1000e: Fix debug printk macro Auke Kok
2007-10-15 21:02 ` [PATCH 2/2] e1000e: fix error checks Auke Kok
2007-10-17 1:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).