From: David Miller <davem@davemloft.net>
To: tina.yang@oracle.com
Cc: mpm@selenic.com, netdev@vger.kernel.org
Subject: Re: [patch] net: avoid race between netpoll and network fast path
Date: Tue, 16 Oct 2007 21:06:13 -0700 (PDT) [thread overview]
Message-ID: <20071016.210613.71104656.davem@davemloft.net> (raw)
In-Reply-To: <47158540.7000709@oracle.com>
From: Tina Yang <tina.yang@oracle.com>
Date: Tue, 16 Oct 2007 20:45:04 -0700
> The current netpoll design and implementation has serveral race issues with the
> network fast path that panics/hangs the system or causes interface timeout/reset
> but the fix is likely to have impact on the overall system performance and could
> involve a large number of drivers. The proposal is to disable the problem code
> for normal operations but only to enable it at the time of crash in case polling
> is necessary. Tests that have been done included the bug fix verification
> as well as regression check on the netlog results in various crash modes.
>
> Signed-off-by: Tina Yang <tina.yang@oracle.com>
This is at best a kludge, and it's the wrong way to approach this problem.
Fix the bug, and fix it right.
If you disable that stretch of code, what you've done is make the
netpoll code hang and/or drop console messages if the TX queue is full
in the driver and the only way to liberate TX space is to call into
->poll().
You haven't shown the precise race that leads to corruption so that someone
so motivated can guide you towards a more correct fix if you are not
capable of implementing it properly on your own.
next prev parent reply other threads:[~2007-10-17 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 3:45 [patch] net: avoid race between netpoll and network fast path Tina Yang
2007-10-17 4:06 ` David Miller [this message]
2007-10-17 5:46 ` Tina Yang
2007-10-30 4:26 ` David Miller
2007-10-30 5:08 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016.210613.71104656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=tina.yang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).