From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: benh@kernel.crashing.org, netdev@vger.kernel.org
Subject: Re: netif_napi_add vs. multiple netdev's
Date: Tue, 16 Oct 2007 16:37:24 -0700 [thread overview]
Message-ID: <20071016163724.28fc1df0@freepuppy.rosehill> (raw)
In-Reply-To: <20071016.151616.70218795.davem@davemloft.net>
On Tue, 16 Oct 2007 15:16:16 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Tue, 16 Oct 2007 09:10:35 -0700
>
> > On Tue, 16 Oct 2007 15:47:13 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > The way it's currently implemented, there's a list of NAPI's attached to
> > > the netdev, so obviously, that won't work for my usage scenario.
> >
> > sky2 driver has potentially 2 ports for 1 NAPI instance.
>
> And it's unfortunately buggy.
>
> For example, the sky2_suspend() code iterates over the ports
> and calls sky2_down() on each one that is up.
>
> That will call napi_disable() on the same NAPI instance if
> multiple ports are up, and thus hang the machine.
>
> This is why, Stephen, for the second time, I'm telling you
> that perhaps you should put the NAPI instance into the
> sky2_port struct.
It isn't possible, there is only one hardware IRQ, and one
common status buffer. I'll fix the suspend code, it has other
problems as well.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-16 23:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:47 netif_napi_add vs. multiple netdev's Benjamin Herrenschmidt
2007-10-16 16:10 ` Stephen Hemminger
2007-10-16 22:16 ` David Miller
2007-10-16 22:24 ` Benjamin Herrenschmidt
2007-10-16 23:37 ` Stephen Hemminger [this message]
2007-10-16 23:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016163724.28fc1df0@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox