From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Fenkes Subject: Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers Date: Tue, 16 Oct 2007 23:20:00 +0200 Message-ID: <200710162320.00630.fenkes@de.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan-Bernd Themann , Paul Mackerras , Christoph Raisch , Hoang-Nam Nguyen , LKML , "LinuxPPC-Dev" , Paul Mackerras , Stefan Roscher , Thomas Q Klein , netdev@vger.kernel.org, Marcus Eder To: Jeff Garzik Return-path: Received: from mtagate2.uk.ibm.com ([195.212.29.135]:28268 "EHLO mtagate2.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755248AbXJPOUh convert rfc822-to-8bit (ORCPT ); Tue, 16 Oct 2007 10:20:37 -0400 In-Reply-To: Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote: > Roland Dreier wrote on 03.10.2007 20:05:44: > > > > Replace struct ibmebus_dev and struct ibmebus_driver with stru= ct=20 of_device > > > > and struct of_platform_driver, respectively. Match the externa= l=20 ibmebus > > > > interface and drivers using it. > > > > > > > > Signed-off-by: Joachim Fenkes > > > > > > This is somewhat difficult as this patch touches files that are = the > > > responsibility of three different maintainers. =A0Is it possible= to > > > split the patch into three, one for each maintainer (possibly by > > > keeping both old and new interfaces around for a little while)? > > >=20 > > > If not, then you need to get an Acked-by and an agreement that t= his > > > change can go via the powerpc.git tree from Roland Dreier and Je= ff > > > Garzik. > > > > I don't see anything objectionable in the infiniband parts of the > > patch -- I don't have any way to test the changes but it all looks > > like a straightforward conversion to a new platform API. So: > > > > Acked-by: Roland Dreier > > > > - R. > > Looks good from eHEA driver perspective. > > Acked-by: Jan-Bernd Themann Jeff, do you have any objections against this patch going into the kern= el via Paul's powerpc.git tree? It touches only a few lines of ehea which = are specific to the bus interface changes. You can see the full patch here: http://patchwork.ozlabs.org/linuxppc/patch?id=3D13750 If you have no objections, please ack the patch so Paul can include it. Thanks and regards, Joachim