From: Stephen Hemminger <shemminger@linux-foundation.org>
To: benh@kernel.crashing.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] napi_synchronize: waiting for NAPI
Date: Wed, 17 Oct 2007 18:26:28 -0700 [thread overview]
Message-ID: <20071017182628.6590fcdd@freepuppy.rosehill> (raw)
In-Reply-To: <1192667289.12879.0.camel@pasglop>
On Thu, 18 Oct 2007 10:28:09 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Wed, 2007-10-17 at 13:26 -0700, Stephen Hemminger wrote:
> > plain text document attachment (napi-synchronize.patch)
> > Some drivers with shared NAPI need a synchronization barrier.
> > Also suggested by Benjamin Herrenschmidt for EMAC.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> Just saw this patch, sorry, missed it. Same as you sent me on another
> reply, I still think it needs the smp barrier. Can you have a look at
> the one I posted today ?
>
> Cheers,
> Ben.
Could you give a concrete example as to why it needs a smp barrier?
The test_bit is going to get a consistent result. Are you worried about
operations ordering before the test_bit()? In that case, one of those
smp_mb__before_xxx functions is probably what is needed.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-18 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071017202640.171902388@linux-foundation.org>
2007-10-17 20:26 ` [PATCH 1/2] napi_synchronize: waiting for NAPI Stephen Hemminger
2007-10-18 0:21 ` Jeff Garzik
2007-10-18 0:28 ` Benjamin Herrenschmidt
2007-10-18 1:26 ` Stephen Hemminger [this message]
2007-10-18 1:33 ` Benjamin Herrenschmidt
2007-10-17 20:26 ` [PATCH 2/2] sky2: shutdown cleanup Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017182628.6590fcdd@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox