[patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

[patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

[akpm]

From: Andrew Morton <akpm@linux-foundation.org>

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Emil Medve <Emilian.Medve@Freescale.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Li Yang <leoli@freescale.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/ucc_geth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes drivers/net/ucc_geth.c
--- a/drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes
+++ a/drivers/net/ucc_geth.c
@@ -3454,7 +3454,7 @@ static int ucc_geth_rx(struct ucc_geth_p
 	u16 length, howmany = 0;
 	u32 bd_status;
 	u8 *bdBuffer;
-	struct net_device * dev;
+	struct net_device *dev;
 
 	ugeth_vdbg("%s: IN", __FUNCTION__);
 
_

Re: [patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

[David Miller]

From: akpm@linux-foundation.org
Date: Tue, 16 Oct 2007 14:24:12 -0700

> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Emil Medve <Emilian.Medve@Freescale.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Kumar Gala <galak@gate.crashing.org>
> Cc: Li Yang <leoli@freescale.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Please help my eyes, I can't see the fix:

> @@ -3454,7 +3454,7 @@ static int ucc_geth_rx(struct ucc_geth_p
>  	u16 length, howmany = 0;
>  	u32 bd_status;
>  	u8 *bdBuffer;
> -	struct net_device * dev;
> +	struct net_device *dev;
>  
>  	ugeth_vdbg("%s: IN", __FUNCTION__);
>  

This might be a coding style fix, as far as I can see, but I can't
imagine how it can effect compilation at all.  It just removes a space
between the "*" and "dev" but that space is harmless.

Re: [patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

[Andrew Morton]

On Wed, 17 Oct 2007 19:37:21 -0700 (PDT) David Miller <davem@davemloft.net> wrote:

> From: akpm@linux-foundation.org
> Date: Tue, 16 Oct 2007 14:24:12 -0700
> 
> > From: Andrew Morton <akpm@linux-foundation.org>
> > 
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Emil Medve <Emilian.Medve@Freescale.com>
> > Cc: Jeff Garzik <jeff@garzik.org>
> > Cc: Kumar Gala <galak@gate.crashing.org>
> > Cc: Li Yang <leoli@freescale.com>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Please help my eyes, I can't see the fix:
> 
> > @@ -3454,7 +3454,7 @@ static int ucc_geth_rx(struct ucc_geth_p
> >  	u16 length, howmany = 0;
> >  	u32 bd_status;
> >  	u8 *bdBuffer;
> > -	struct net_device * dev;
> > +	struct net_device *dev;
> >  
> >  	ugeth_vdbg("%s: IN", __FUNCTION__);
> >  
> 
> This might be a coding style fix, as far as I can see, but I can't
> imagine how it can effect compilation at all.  It just removes a space
> between the "*" and "dev" but that space is harmless.

uh, this is fallout from the akpmbot.

- Someone sent a patch which I named foo.patch

- When I applied it I saw valid checkpatch warnings, so I queed a patch to
fix them, called foo-checkpatch-fixes.patch with the intention that it later be
folded into foo.patch

- You merged foo.patch.  But foo-checkpatch-fixes.patch still applied, so I
retained it.

- I sent you the runt foo-checkpatch-fixes.patch.

Normally when this happens I'll just curse the original patch author and
drop foo-checkpatch-fixes.patch.  This time I didn't notice.

(Perhaps people should be adding a checkpatch run to their git-commit
scripts..)

Re: [patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

[Andrew Morton]

On Wed, 17 Oct 2007 19:47:59 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> - When I applied it I saw valid checkpatch warnings, so I queed a patch to
> fix them, called foo-checkpatch-fixes.patch with the intention that it later be
> folded into foo.patch

incidentally, the reason I do it this way is to attempt to educate
patch originators into running checkpatch, rather than out of sheer joy for
the task.  Hopefully I'll have to do this less often as time passes.

box:/usr/src/25> ls -lR patches|grep checkpatch-fixes | wc -l 
38