From: Andrew Morton <akpm@linux-foundation.org>
To: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Cc: Jeff Garzik <jeff@garzik.org>,
Badari Pulavarty <pbadari@us.ibm.com>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
satyam@infradead.org
Subject: Re: [PATCH] vortex_up should initialize "err"
Date: Wed, 17 Oct 2007 23:58:19 -0700 [thread overview]
Message-ID: <20071017235819.25bf1d5d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071018060506.GA30544@newton.mathematik.tu-chemnitz.de>
On Thu, 18 Oct 2007 08:05:06 +0200 Steffen Klassert <klassert@mathematik.tu-chemnitz.de> wrote:
> On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
> > Badari Pulavarty wrote:
> > >Simple compile warning fix. (against 2.6.23-git12)
> > >
> > >Thanks,
> > >Badari
> > >
> > >vortex_up() should initialize 'err' for a successful return.
> > >
> > >drivers/net/3c59x.c: In function `vortex_up':
> > >drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in
> > >this function
> >
> > applied as an obvious bug fix (Steffen added to CC)
> >
>
> Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from
> Satyam Sharma in -mm to fix this, but the patch was removed from -mm
> some time ago. Andrew, what happened to this one?
It's fixed in Jeff's netdev tree.
prev parent reply other threads:[~2007-10-18 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 23:15 [PATCH] vortex_up should initialize "err" Badari Pulavarty
2007-10-18 0:28 ` Jeff Garzik
2007-10-18 6:05 ` Steffen Klassert
2007-10-18 6:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017235819.25bf1d5d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).