From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: benh@kernel.crashing.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
mingo@elte.hu, tglx@linutronix.de, torvalds@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [NET]: Fix possible dev_deactivate race condition
Date: Thu, 18 Oct 2007 22:38:20 -0700 (PDT) [thread overview]
Message-ID: <20071018.223820.49264165.davem@davemloft.net> (raw)
In-Reply-To: <20071019053624.GA10560@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 19 Oct 2007 13:36:24 +0800
> [NET]: Fix possible dev_deactivate race condition
>
> The function dev_deactivate is supposed to only return when
> all outstanding transmissions have completed. Unfortunately
> it is possible for store operations in the driver's transmit
> function to only become visible after dev_deactivate returns.
>
> This patch fixes this by taking the queue lock after we see
> the end of the queue run. This ensures that all effects of
> any previous transmit calls are visible.
>
> If however we detect that there is another queue run occuring,
> then we'll warn about it because this should never happen as
> we have pointed dev->qdisc to noop_qdisc within the same queue
> lock earlier in the functino.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert!
next prev parent reply other threads:[~2007-10-19 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1IiWnJ-0000ne-00@gondolin.me.apana.org.au>
[not found] ` <1192745137.7367.40.camel@pasglop>
[not found] ` <alpine.LFD.0.999.0710181549330.26902@woody.linux-foundation.org>
[not found] ` <1192749449.7367.51.camel@pasglop>
[not found] ` <alpine.LFD.0.999.0710181627091.26902@woody.linux-foundation.org>
[not found] ` <20071019023219.GB8453@gondor.apana.org.au>
[not found] ` <alpine.LFD.0.999.0710181941020.26902@woody.linux-foundation.org>
[not found] ` <alpine.LFD.0.999.0710182007170.26902@woody.linux-foundation.org>
[not found] ` <20071019042025.GA9617@gondor.apana.org.au>
2007-10-19 5:36 ` [NET]: Fix possible dev_deactivate race condition Herbert Xu
2007-10-19 5:38 ` David Miller [this message]
2007-10-19 7:35 ` Peter Zijlstra
2007-10-19 9:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018.223820.49264165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox