s390x: getting ipv6 bugs on mainline since 2.6.23-git3

s390x: getting ipv6 bugs on mainline since 2.6.23-git3

[Andy Whitcroft]

Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
when booting latest mainline releases, specifically since 2.6.23-git3.

Kernel BUG at 0000000000000002 Ýverbose debug info unavailable¨
illegal operation: 0001 Ý#1¨
Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup qdio dasd_fba_mod dasd_
eckd_mod dasd_mod
CPU:    0    Not tainted
Process ip (pid: 2614, task: 000000003f42f680, ksp: 000000003cf2feb8)
Krnl PSW : 0704200180000000 0000000000000002 (0x2)
           R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3
Krnl GPRS: 0000000000000000 0000000000000000 000000003e6d5d00 000000003e01f000
           00000000000086dd 000000003cdac144 0000000000000000 0000000000000010
           000000003e01f000 000000003d97e3c0 0000000100eaaa00 000000003cdac100
           000000003e6d5d00 00000001018fb1d0 0000000000286da8 000000003cf2f5e8
Krnl Code:>0000000000000002: 0000               unknown
           0000000000000004: 0000               unknown
           0000000000000006: 0000               unknown
           0000000000000008: 0000               unknown
           000000000000000a: 0000               unknown
           000000000000000c: 0000               unknown
           000000000000000e: 0000               unknown
           0000000000000010: 0000               unknown
Call Trace:
(Ý<0000000000286d60>¨ neigh_connected_output+0x68/0xfc)
 Ý<00000001018cc7fe>¨ ip6_output2+0x416/0x4ac Ýipv6¨
 Ý<00000001018ceaa8>¨ ip6_output+0xfc4/0xfd4 Ýipv6¨
 Ý<00000001018dfe40>¨ __ndisc_send+0x52c/0x6f0 Ýipv6¨
 Ý<00000001018e0218>¨ ndisc_send_rs+0x4c/0x5c Ýipv6¨
 Ý<00000001018d40e6>¨ addrconf_dad_completed+0xa2/0xf0 Ýipv6¨
 Ý<00000001018d4880>¨ addrconf_dad_start+0xa0/0x124 Ýipv6¨
 Ý<00000001018d496a>¨ addrconf_add_linklocal+0x66/0x98 Ýipv6¨
 Ý<00000001018d7a3c>¨ addrconf_notify+0x6cc/0x898 Ýipv6¨
 Ý<000000000004ad7c>¨ notifier_call_chain+0x50/0x8c
 Ý<000000000004b0b6>¨ __raw_notifier_call_chain+0x1a/0x28
 Ý<000000000004b0e6>¨ raw_notifier_call_chain+0x22/0x30
 Ý<000000000027f014>¨ call_netdevice_notifiers+0x28/0x38
 Ý<0000000000281732>¨ dev_open+0xba/0xd0
 Ý<0000000000281cce>¨ dev_change_flags+0xbe/0x198
 Ý<00000000002d681c>¨ devinet_ioctl+0x2c8/0x6c0
 Ý<000000000027138a>¨ sock_ioctl+0x26e/0x2a0
 Ý<00000000000ab1ce>¨ do_ioctl+0x4a/0xac
 Ý<00000000000ab5f2>¨ vfs_ioctl+0x3c2/0x3d8
 Ý<00000000000ab676>¨ sys_ioctl+0x6e/0x94
 Ý<00000000000215c6>¨ sysc_noemu+0x10/0x16
 Ý<00000200001201ca>¨ 0x200001201ca

 <0>Kernel panic - not syncing: Fatal exception in interrupt
01: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 00.
02: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 00.
03: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 00.
00: HCPGIR450W CP entered; disabled wait PSW 00020001 80000000 00000000 00015FDE

-apw

Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3

[Patrick McHardy]

Andy Whitcroft wrote:
> Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
> when booting latest mainline releases, specifically since 2.6.23-git3.
> 
> Kernel BUG at 0000000000000002 Ýverbose debug info unavailable?
> illegal operation: 0001 Ý#1?
> Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup qdio dasd_fba_mod dasd_
> eckd_mod dasd_mod
> CPU:    0    Not tainted
> Process ip (pid: 2614, task: 000000003f42f680, ksp: 000000003cf2feb8)
> Krnl PSW : 0704200180000000 0000000000000002 (0x2)
>            R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3
> Krnl GPRS: 0000000000000000 0000000000000000 000000003e6d5d00 000000003e01f000
>            00000000000086dd 000000003cdac144 0000000000000000 0000000000000010
>            000000003e01f000 000000003d97e3c0 0000000100eaaa00 000000003cdac100
>            000000003e6d5d00 00000001018fb1d0 0000000000286da8 000000003cf2f5e8
> Krnl Code:>0000000000000002: 0000               unknown
>            0000000000000004: 0000               unknown
>            0000000000000006: 0000               unknown
>            0000000000000008: 0000               unknown
>            000000000000000a: 0000               unknown
>            000000000000000c: 0000               unknown
>            000000000000000e: 0000               unknown
>            0000000000000010: 0000               unknown
> Call Trace:
> (Ý<0000000000286d60>? neigh_connected_output+0x68/0xfc)


Which network driver are you using? Please post the output of
"ip link list <dev>".

Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3

[Martin Schwidefsky]

On Thu, 2007-10-18 at 11:43 +0200, Patrick McHardy wrote:
> Andy Whitcroft wrote:
> > Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
> > when booting latest mainline releases, specifically since 2.6.23-git3.
> > 
> > Kernel BUG at 0000000000000002 Ýverbose debug info unavailable?
> > illegal operation: 0001 Ý#1?
> Which network driver are you using? Please post the output of
> "ip link list <dev>".

This is a bug in the qeth driver. It has been introduced by this commit:

commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
Author: Stephen Hemminger <shemminger@linux-foundation.org>
Date:   Tue Oct 9 01:40:57 2007 -0700

    [NET]: Move hardware header operations out of netdevice.

    Since hardware header operations are part of the protocol class
    not the device instance, make them into a separate object and
    save memory.

    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

I've hacked up a fix for it. The real fix will be done by our networking
people.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.

---

 drivers/s390/net/qeth_main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -urpN linux-2.6/drivers/s390/net/qeth_main.c linux-2.6-patched/drivers/s390/net/qeth_main.c
--- linux-2.6/drivers/s390/net/qeth_main.c	2007-10-17 15:05:36.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/qeth_main.c	2007-10-17 15:05:46.000000000 +0200
@@ -6643,7 +6643,8 @@ qeth_netdev_init(struct net_device *dev)
 	dev->vlan_rx_kill_vid = qeth_vlan_rx_kill_vid;
 	dev->vlan_rx_add_vid = qeth_vlan_rx_add_vid;
 #endif
-	dev->header_ops = &qeth_null_ops;
+	if (qeth_get_netdev_flags(card) & IFF_NOARP)
+		dev->header_ops = &qeth_null_ops;
 
 #ifdef CONFIG_QETH_IPV6
 	/*IPv6 address autoconfiguration stuff*/