From: Andy Whitcroft <apw@shadowen.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: leoli@freescale.com, jgarzik@pobox.com, paulus@samba.org,
galak@kernel.crashing.org, afleming@freescale.com,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement
Date: Thu, 18 Oct 2007 10:40:13 +0100 [thread overview]
Message-ID: <20071018094013.GU21136@shadowen.org> (raw)
In-Reply-To: <20071017195746.GA15592@localhost.localdomain>
The check then is to see if a non {}'d block has no statements in it if the
ifdef is null. Hmmm. May be possible. Will think on it.
if (err)
+#ifdef CONFIG_GFAR_NAPI
napi_disable(&priv->napi);
+#endif
-apw
prev parent reply other threads:[~2007-10-18 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 19:57 [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement Anton Vorontsov
2007-10-18 0:21 ` Jeff Garzik
2007-10-18 9:40 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018094013.GU21136@shadowen.org \
--to=apw@shadowen.org \
--cc=afleming@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=galak@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).