netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jdelvare@suse.de, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH 1/2] net: Let inet_diag and friends autoload
Date: Fri, 19 Oct 2007 01:34:05 -0700 (PDT)	[thread overview]
Message-ID: <20071019.013405.64830631.davem@davemloft.net> (raw)
In-Reply-To: <E1Iin6h-000367-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 19 Oct 2007 16:21:23 +0800

> David Miller <davem@davemloft.net> wrote:
> >
> > I'm concerned it might be dangerous to load the module in
> > this context, the RTNL semaphore is held and the module we
> > are requesting could easily try to take it and deadlock.
> 
> We shouldn't be holding the RTNL here.  AFAICS we only hold
> inet_diag_mutex which is used in just one spot.

You're right.

I'll reconsider these patches.

      reply	other threads:[~2007-10-19  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 15:28 [PATCH 1/2] net: Let inet_diag and friends autoload Jean Delvare
2007-10-18  2:51 ` David Miller
2007-10-19  8:21   ` Herbert Xu
2007-10-19  8:34     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071019.013405.64830631.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jdelvare@suse.de \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).