From: Christoph Hellwig <hch@infradead.org>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Dale Farnsworth <dale@farnsworth.org>,
Nicolas Pitre <nico@marvell.com>,
Tzachi Perelstein <tzachi@marvell.com>,
Manas Saksena <msaksena@marvell.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header
Date: Fri, 19 Oct 2007 09:30:48 +0100 [thread overview]
Message-ID: <20071019083048.GA16865@infradead.org> (raw)
In-Reply-To: <20071019021010.GD16037@xi.wantstofly.org>
On Fri, Oct 19, 2007 at 04:10:10AM +0200, Lennert Buytenhek wrote:
> Move the mv643xx's ethernet-related register definitions from
> include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since
> they aren't of any use outside the ethernet driver.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> Acked-by: Tzachi Perelstein <tzachi@marvell.com>
>
> Index: linux-2.6/drivers/net/mv643xx_eth.h
> ===================================================================
> --- linux-2.6.orig/drivers/net/mv643xx_eth.h
> +++ linux-2.6/drivers/net/mv643xx_eth.h
> @@ -7,7 +7,7 @@
> #include <linux/workqueue.h>
> #include <linux/mii.h>
>
> -#include <linux/mv643xx.h>
> +#include <linux/mv643xx_eth.h>
Isn't it a little too confusing to have two headers with the same name,
one in drivers/net and one in include/linux?
next prev parent reply other threads:[~2007-10-19 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 2:10 [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header Lennert Buytenhek
2007-10-19 8:30 ` Christoph Hellwig [this message]
2007-10-19 11:09 ` Lennert Buytenhek
2007-10-19 12:56 ` Dale Farnsworth
2007-10-19 14:00 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019083048.GA16865@infradead.org \
--to=hch@infradead.org \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=msaksena@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nico@marvell.com \
--cc=tzachi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).