From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header
Date: Fri, 19 Oct 2007 09:30:48 +0100
Message-ID: <20071019083048.GA16865@infradead.org>
References: <20071019021010.GD16037@xi.wantstofly.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dale Farnsworth <dale@farnsworth.org>,
	Nicolas Pitre <nico@marvell.com>,
	Tzachi Perelstein <tzachi@marvell.com>,
	Manas Saksena <msaksena@marvell.com>, netdev@vger.kernel.org
To: Lennert Buytenhek <buytenh@wantstofly.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from pentafluge.infradead.org ([213.146.154.40]:44402 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755609AbXJSIax (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 19 Oct 2007 04:30:53 -0400
Content-Disposition: inline
In-Reply-To: <20071019021010.GD16037@xi.wantstofly.org>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Fri, Oct 19, 2007 at 04:10:10AM +0200, Lennert Buytenhek wrote:
> Move the mv643xx's ethernet-related register definitions from
> include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since
> they aren't of any use outside the ethernet driver.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> Acked-by: Tzachi Perelstein <tzachi@marvell.com>
> 
> Index: linux-2.6/drivers/net/mv643xx_eth.h
> ===================================================================
> --- linux-2.6.orig/drivers/net/mv643xx_eth.h
> +++ linux-2.6/drivers/net/mv643xx_eth.h
> @@ -7,7 +7,7 @@
>  #include <linux/workqueue.h>
>  #include <linux/mii.h>
>  
> -#include <linux/mv643xx.h>
> +#include <linux/mv643xx_eth.h>

Isn't it a little too confusing to have two headers with the same name,
one in drivers/net and one in include/linux?