[PATCH 2/7] tg3: MII => TP

[PATCH 2/7] tg3: MII => TP

[Matt Carlson]

This patch changes the PHY type reported through ethtool for copper
devices from MII to TP.  The latter is more accurate.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 253d761..66682b8 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -8274,7 +8274,7 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 				  SUPPORTED_100baseT_Full |
 				  SUPPORTED_10baseT_Half |
 				  SUPPORTED_10baseT_Full |
-				  SUPPORTED_MII);
+				  SUPPORTED_TP);
 		cmd->port = PORT_TP;
 	} else {
 		cmd->supported |= SUPPORTED_FIBRE;

linux kernel networking code review request

[Templin, Fred L]

Hello,

I would like to get a review on some new Linux
kernel networking code. The code is based on the
2.6.23 source tree and touches three files - two
in ./net/ipv6 and one in ./include/net. What is
the proper procedure for requesting a review?

Thanks - Fred
fred.l.templin@boeing.com

Re: linux kernel networking code review request

[Dmitry Torokhov]

On Friday 19 October 2007, Templin, Fred L wrote:
> Hello,
> 
> I would like to get a review on some new Linux
> kernel networking code. The code is based on the
> 2.6.23 source tree and touches three files - two
> in ./net/ipv6 and one in ./include/net. What is
> the proper procedure for requesting a review?
> 

Just don your flameproof pants and post the changes here ;)

-- 
Dmitry

Re: linux kernel networking code review request

[Ilpo Järvinen]

On Fri, 19 Oct 2007, Dmitry Torokhov wrote:

> On Friday 19 October 2007, Templin, Fred L wrote:
> > Hello,
> > 
> > I would like to get a review on some new Linux
> > kernel networking code. The code is based on the
> > 2.6.23 source tree and touches three files - two
> > in ./net/ipv6 and one in ./include/net. What is
> > the proper procedure for requesting a review?
> > 
> 
> Just don your flameproof pants and post the changes here ;)

In addition, check what is being said in Documentation/SubmittingPatches

:-)

-- 
 i.

Re: [PATCH 2/7] tg3: MII => TP

[David Miller]

From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 19 Oct 2007 14:36:42 -0700

> This patch changes the PHY type reported through ethtool for copper
> devices from MII to TP.  The latter is more accurate.
> 
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>

You should set both MII and TP, since these copper interfaces
have a MII based twisted-pair physical layer.

Re: [PATCH 2/7] tg3: MII => TP

[Michael Chan]

David Miller wrote:

> From: "Matt Carlson" <mcarlson@broadcom.com>
> Date: Fri, 19 Oct 2007 14:36:42 -0700
> 
> > This patch changes the PHY type reported through ethtool for copper
> > devices from MII to TP.  The latter is more accurate.
> > 
> > Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
> 
> You should set both MII and TP, since these copper interfaces
> have a MII based twisted-pair physical layer.
> 
> 

MII in this ethtool context means an MII connector on the card
that can connect to an external transceiver, right?

Or does it mean internal MII interface to the PHY?

Re: [PATCH 2/7] tg3: MII => TP

[David Miller]

From: "Michael Chan" <mchan@broadcom.com>
Date: Sun, 21 Oct 2007 20:49:25 -0700

> MII in this ethtool context means an MII connector on the card
> that can connect to an external transceiver, right?
> 
> Or does it mean internal MII interface to the PHY?

Good question.  Looking at drivers it's set randomly.

Probably you are right and it's supposed to mean you can specify
PORT_MII in ethtool_cmd->port to select the external MII connector.

Please resubmit this change after the PCI error recovery
issues are resolved.

Thanks.