From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linas@austin.ibm.com, mchan@broadcom.com
Subject: Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function
Date: Sun, 21 Oct 2007 16:21:31 -0700 (PDT) [thread overview]
Message-ID: <20071021.162131.43417026.davem@davemloft.net> (raw)
In-Reply-To: <1192829817.22064.559.camel@teletran1>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Fri, 19 Oct 2007 14:36:56 -0700
> This patch exports the pci_restore_msi_state() function. This function
> is needed to restore the MSI state during PCI error recovery.
>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
I'm not so sure about this.
Perhaps, instead, you should do a pci_msi_disable() and
pci_msi_enable() in the error detection and recovery sequence.
Or, alternatively, save/restore those MSI registers by hand.
I'm trying to figure out how the E1000 driver handles this correctly,
but I can't see it just by reading it over quickly.
next prev parent reply other threads:[~2007-10-21 23:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 21:36 [PATCH 5/7] pci: Export the pci_restore_msi_state() function Matt Carlson
2007-10-19 23:29 ` Linas Vepstas
2007-10-20 0:36 ` Michael Chan
2007-10-20 0:04 ` Linas Vepstas
2007-10-20 0:27 ` David Miller
2007-10-20 0:46 ` [BUG] powerpc does not save msi state [was " Linas Vepstas
2007-10-20 0:53 ` David Miller
2007-10-20 6:43 ` Michael Ellerman
2007-10-20 22:50 ` Michael Chan
2007-10-21 21:13 ` Benjamin Herrenschmidt
2007-10-22 19:54 ` Linas Vepstas
2007-10-23 0:23 ` David Miller
2007-10-23 0:32 ` Benjamin Herrenschmidt
2007-10-20 1:29 ` Benjamin Herrenschmidt
2007-10-20 1:12 ` Michael Chan
2007-10-20 0:25 ` Linas Vepstas
2007-10-21 23:21 ` David Miller [this message]
2007-10-22 1:49 ` Michael Ellerman
2007-10-22 18:13 ` Linas Vepstas
2007-10-22 21:24 ` Benjamin Herrenschmidt
2007-10-23 0:13 ` Linas Vepstas
2007-10-23 0:29 ` Benjamin Herrenschmidt
2007-10-23 4:20 ` Michael Ellerman
2007-10-22 4:01 ` Michael Chan
2007-10-22 4:45 ` David Miller
2007-10-22 18:19 ` Linas Vepstas
2007-10-22 18:07 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071021.162131.43417026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linas@austin.ibm.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).