From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH 1/4] Use the skb_set_queue_mapping where appropriate
Date: Sun, 21 Oct 2007 17:01:03 -0700 (PDT) [thread overview]
Message-ID: <20071021.170103.85417880.davem@davemloft.net> (raw)
In-Reply-To: <47187244.1010603@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 19 Oct 2007 13:00:52 +0400
> There's already such a helper to initialize this field.
> Use it.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied.
> /* reset queue_mapping to zero */
> - skb->queue_mapping = 0;
> + skb_set_queue_mapping(skb, 0);
This right here is a great example why I add next to no comments to
the code I write. They are %99.999 of the time stating the obvious,
and where a comment is needed it's the code's fault and the code in
such cases could be rewritten to make what's going on more clear thus
making any commentary, again, redundant and stating the obvious.
Here the case is the former, it's of the form:
/* Add one to 'a'! */
a += 1;
Gee thanks for letting me know! How insightful! :-))
next prev parent reply other threads:[~2007-10-22 0:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 8:59 [PATCH 0/4] Diet struct sk_buff a bit Pavel Emelyanov
2007-10-19 9:00 ` [PATCH 1/4] Use the skb_set_queue_mapping where appropriate Pavel Emelyanov
2007-10-22 0:01 ` David Miller [this message]
2007-10-19 9:02 ` [PATCH 2/4] Make and use skb_get_queue_mapping Pavel Emelyanov
2007-10-22 0:01 ` David Miller
2007-10-19 9:04 ` [PATCH 3/4] Hide the queue_mapping field inside netif_subqueue_stopped Pavel Emelyanov
2007-10-22 0:02 ` David Miller
2007-10-19 9:05 ` [PATCH 4/4] Cut off the queue_mapping field from sk_buff Pavel Emelyanov
2007-10-22 0:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071021.170103.85417880.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).