From: David Miller <davem@davemloft.net>
To: drzeus@drzeus.cx
Cc: netdev@vger.kernel.org
Subject: Re: net: alignment problem in icmp code
Date: Mon, 22 Oct 2007 01:31:05 -0700 (PDT) [thread overview]
Message-ID: <20071022.013105.74746322.davem@davemloft.net> (raw)
In-Reply-To: <20071022092350.5c75b3bd@poseidon.drzeus.cx>
From: Pierre Ossman <drzeus@drzeus.cx>
Date: Mon, 22 Oct 2007 09:23:50 +0200
> As for other instances of unaligned accesses, is there any active
> work on getting rid of those? And would you accept more patches for
> fixing them? (Code complexity being the downside)
On fast paths we aren't going to add things like get_unaligned()
calls.
Every architecture should handle unaligned accesses properly, and for
the fast paths the network driver should provide the packet fully
aligned or take steps to make it so if it can't DMA directly into
2-byte offset buffers (such as copying the packet).
What is the specific reason why you see packet headers unaligned?
It's probably just some AVR networking driver that needs tweaks.
next prev parent reply other threads:[~2007-10-22 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 21:35 net: alignment problem in icmp code Pierre Ossman
2007-10-21 5:12 ` David Miller
2007-10-21 9:34 ` Pierre Ossman
2007-10-21 19:48 ` David Miller
2007-10-21 21:21 ` Pierre Ossman
2007-10-21 23:02 ` David Miller
2007-10-22 4:54 ` Pierre Ossman
2007-10-22 5:15 ` David Miller
2007-10-22 7:23 ` Pierre Ossman
2007-10-22 8:31 ` David Miller [this message]
2007-10-22 8:42 ` Pierre Ossman
2007-10-22 9:05 ` David Miller
2007-10-22 9:26 ` Pierre Ossman
2007-10-22 9:52 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022.013105.74746322.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drzeus@drzeus.cx \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).