netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: David Mack <dmack@juniper.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org, esandeen@redhat.com
Subject: Re: e100 problems in .23rc8 ?
Date: Sun, 21 Oct 2007 21:04:40 -0400	[thread overview]
Message-ID: <20071022010440.GA11165@redhat.com> (raw)
In-Reply-To: <47179F1F.3030202@intel.com>

On Thu, Oct 18, 2007 at 10:59:59AM -0700, Kok, Auke wrote:
 > David Mack wrote:
 > > It appears that the needed e100 fix made it into the Fedora
 > > 2.6.23.1-23.fc8 kernel. Boots reliably now.
 > > 
 > > Huge thanks and great work, guys.
 > 
 > DaveJ, I didn't push anything upstream. Can you verify this now works?

There was no e100 changes in the kernel above, so David just
got lucky. (The race doesn't always occur, so it sometimes appears
something got fixed.).

I included the patch below in the latest build, but I've not had
chance to try it on an e100 box yet..

	Dave

--- linux-2.6.23.noarch/drivers/net/e100.c~	2007-10-18 16:10:40.000000000 -0400
+++ linux-2.6.23.noarch/drivers/net/e100.c	2007-10-18 16:16:02.000000000 -0400
@@ -2682,6 +2682,8 @@ static int __devinit e100_probe(struct p
 	if (err)
 		DPRINTK(PROBE, ERR, "Error clearing wake event\n");
 
+	netif_poll_disable(netdev);
+
 	strcpy(netdev->name, "eth%d");
 	if((err = register_netdev(netdev))) {
 		DPRINTK(PROBE, ERR, "Cannot register net device, aborting.\n");

-- 
http://www.codemonkey.org.uk

  parent reply	other threads:[~2007-10-22  1:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 15:04 e100 problems in .23rc8 ? Dave Jones
2007-09-26 18:10 ` Kok, Auke
2007-09-26 18:18   ` Dave Jones
2007-09-27  6:58   ` Herbert Xu
2007-10-11  0:36     ` Dave Jones
2007-10-11  1:25       ` Herbert Xu
2007-10-11 16:10         ` Kok, Auke
2007-10-11 17:25           ` Dave Jones
2007-10-11 18:56             ` Eric Sandeen
2007-10-12 14:54             ` David Mack
2007-10-12 15:35               ` Herbert Xu
2007-10-12 15:51                 ` David Mack
2007-10-13  2:35                   ` Herbert Xu
2007-10-16 14:33                     ` Eric Sandeen
2007-10-16 14:35                       ` Herbert Xu
2007-10-16 15:47                         ` Eric Sandeen
2007-10-16 16:39                         ` David Mack
2007-10-12 17:04                 ` Kok, Auke
2007-10-18 17:51                   ` David Mack
2007-10-18 17:59                     ` Kok, Auke
2007-10-18 18:17                       ` Chuck Ebbert
2007-10-22  1:04                       ` Dave Jones [this message]
2007-10-22  3:10                         ` Herbert Xu
2007-10-22 14:05                         ` David Mack
2007-10-22 14:59                           ` Eric Sandeen
2007-10-22 14:44                       ` Chuck Ebbert
2007-10-11 23:24           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071022010440.GA11165@redhat.com \
    --to=davej@redhat.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=dmack@juniper.net \
    --cc=esandeen@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).