From: Oliver Neukum <oliver@neukum.org>
To: linux-usb-devel@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] USB: net: Fix asix read transfer buffer allocations.
Date: Mon, 22 Oct 2007 19:29:03 +0200 [thread overview]
Message-ID: <200710221929.04035.oliver@neukum.org> (raw)
In-Reply-To: <20071022155053.GA28526@ru.mvista.com>
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
> static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
> {
> struct usbnet *dev = netdev_priv(netdev);
> + void *buf;
> u16 res;
>
> mutex_lock(&dev->phy_mutex);
> asix_set_sw_mii(dev);
> +
> + buf = kmalloc(2, GFP_KERNEL);
This is done under lock. Can you allocate the buffer once and reuse it?
Regards
Oliver
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
next prev parent reply other threads:[~2007-10-22 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 15:50 [PATCH] USB: net: Fix asix read transfer buffer allocations Valentine Barshak
2007-10-22 17:29 ` Oliver Neukum [this message]
2007-10-22 19:22 ` Valentine Barshak
2007-10-23 17:00 ` Ingo Oeser
2007-10-23 17:20 ` Valentine Barshak
2007-10-23 17:40 ` Valentine Barshak
2007-10-23 20:00 ` David Brownell
2007-10-24 11:24 ` Valentine Barshak
2007-10-24 11:33 ` Valentine Barshak
2007-10-24 11:33 ` Valentine Barshak
2007-10-24 11:59 ` David Hollis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710221929.04035.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).