netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, dlstevens@us.ibm.com
Subject: Re: [PATCH] UDP: Make use of inet_iif() when doing socket lookups.
Date: Tue, 23 Oct 2007 20:26:04 -0700 (PDT)	[thread overview]
Message-ID: <20071023.202604.71091476.davem@davemloft.net> (raw)
In-Reply-To: <471E403A.7040705@hp.com>

From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Tue, 23 Oct 2007 14:40:58 -0400

> UDP currently uses skb->dev->ifindex which may provide the wrong
> information when the socket bound to a specific interface.
> This patch makes inet_iif() accessible to UDP and makes UDP use it.
> 
> The scenario we are trying to fix is when a client is running on
> the same system and the server and both client and server bind to
> a non-loopback device.
> 
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>

David, could you take a quick look at this one?

I have a hunch that this will have side-effects for multicast
applications and I'd feel better if you went over this patch
with that in mind.

Thanks!

  reply	other threads:[~2007-10-24  3:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 18:40 [PATCH] UDP: Make use of inet_iif() when doing socket lookups Vlad Yasevich
2007-10-24  3:26 ` David Miller [this message]
2007-10-25 21:58 ` David Stevens
2007-10-25 22:36   ` David Miller
2007-10-26  1:55   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023.202604.71091476.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=vladislav.yasevich@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).