netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [2.6 patch] make tcp_match_skb_to_sack() static
@ 2007-10-24 16:23 Adrian Bunk
  2007-10-24 21:39 ` Ilpo Järvinen
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-10-24 16:23 UTC (permalink / raw)
  To: Ilpo Järvinen; +Cc: linux-kernel, netdev

tcp_match_skb_to_sack() can become static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
b734b439219a6251b7deb65dad2307f9c891f680 
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 9288220..603400d 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1204,8 +1204,8 @@ static int tcp_check_dsack(struct tcp_sock *tp, struct sk_buff *ack_skb,
  * which may fail and creates some hassle (caller must handle error case
  * returns).
  */
-int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
-			  u32 start_seq, u32 end_seq)
+static int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
+				 u32 start_seq, u32 end_seq)
 {
 	int in_sack, err;
 	unsigned int pkt_len;


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make tcp_match_skb_to_sack() static
  2007-10-24 16:23 [2.6 patch] make tcp_match_skb_to_sack() static Adrian Bunk
@ 2007-10-24 21:39 ` Ilpo Järvinen
  2007-10-26 10:57   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2007-10-24 21:39 UTC (permalink / raw)
  To: Adrian Bunk, David Miller; +Cc: LKML, Netdev

On Wed, 24 Oct 2007, Adrian Bunk wrote:

> tcp_match_skb_to_sack() can become static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
[...snip...]

Thanks, I should have noticed that right from the beginning...

Added DaveM to recipients.

-- 
 i.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] make tcp_match_skb_to_sack() static
  2007-10-24 21:39 ` Ilpo Järvinen
@ 2007-10-26 10:57   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-26 10:57 UTC (permalink / raw)
  To: ilpo.jarvinen; +Cc: bunk, linux-kernel, netdev

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 25 Oct 2007 00:39:23 +0300 (EEST)

> On Wed, 24 Oct 2007, Adrian Bunk wrote:
> 
> > tcp_match_skb_to_sack() can become static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> [...snip...]
> 
> Thanks, I should have noticed that right from the beginning...

Yep, applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-10-26 10:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 16:23 [2.6 patch] make tcp_match_skb_to_sack() static Adrian Bunk
2007-10-24 21:39 ` Ilpo Järvinen
2007-10-26 10:57   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).