From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused Date: Thu, 25 Oct 2007 18:40:32 -0700 (PDT) Message-ID: <20071025.184032.206866652.davem@davemloft.net> References: <23686.1193353513@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dhowells@redhat.com, netdev@vger.kernel.org, netdev-owner@vger.kernel.org To: dlstevens@us.ibm.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:55253 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753192AbXJZBka (ORCPT ); Thu, 25 Oct 2007 21:40:30 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: David Stevens Date: Thu, 25 Oct 2007 18:27:22 -0700 > dhowells@redhat.com wrote on 10/25/2007 04:05:13 PM: > > > David Stevens wrote: > > > > > What about just removing it, or do you think it's > > > useful for documentation of the order? Either way, > > > > I don't know whether it's intended to be used for something, perhaps a > > debugging macro. Perhaps it should be #if'd out instead. > > It was used for /proc/net/snmp header printing, but > most of the items in it were moved to a different MIB (by me). > The new values are printed in a backward-compatible way, but > maintaining the old order means not using this header map. > So, long-winded way of saying I believe it should be > removed, but I missed that when I made it obsolete. :-) I've checked just such a change into my tree. Thanks!