From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S. Miller" <davem@davemloft.net>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
Joakim Koskela <joakim.koskela@hiit.fi>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [IPSEC]: Forbid BEET + ipcomp for now
Date: Thu, 25 Oct 2007 09:06:18 +0800 [thread overview]
Message-ID: <20071025010618.GA15154@gondor.apana.org.au> (raw)
In-Reply-To: <471F67AE.5010301@6wind.com>
On Wed, Oct 24, 2007 at 05:41:34PM +0200, Nicolas Dichtel wrote:
>
> >+ x->props.header_len = 0;
> >+ switch (x->props.mode) {
> >+ case XFRM_MODE_TRANSPORT:
> >+ break;
> >+ case XFRM_MODE_TUNNEL:
> >+ x->props.header_len += sizeof(struct iphdr);
> I think, the break statement is missing, is it ?
Indeed it is. I'm going to fix this and repost all 3 patches.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-10-25 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 14:58 [0/3] [IPSEC]: Separate inner/outer family processing on output Herbert Xu
2007-10-24 14:59 ` [PATCH 1/3] [IPSEC]: Forbid BEET + ipcomp for now Herbert Xu
[not found] ` <471F67AE.5010301@6wind.com>
2007-10-25 1:06 ` Herbert Xu [this message]
2007-10-24 14:59 ` [PATCH 2/3] [IPSEC]: Move x->outer_mode->output out of locked section Herbert Xu
2007-10-24 14:59 ` [PATCH 3/3] [IPSEC]: Separate inner/outer mode processing on output Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025010618.GA15154@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=joakim.koskela@hiit.fi \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox