From: Thomas Graf <tgraf@suug.ch>
To: Dan Williams <dcbw@redhat.com>
Cc: "Denis V. Lunev" <den@sw.ru>,
netdev@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: Regression in current git - Network Manager fails (bisected)
Date: Thu, 25 Oct 2007 11:06:09 +0200 [thread overview]
Message-ID: <20071025090609.GD8125@postel.suug.ch> (raw)
In-Reply-To: <1193148618.8648.22.camel@localhost.localdomain>
* Dan Williams <dcbw@redhat.com> 2007-10-23 10:10
> Should I make NM disable ACKs for now until it gets fixed?
The reason libnl enables ACKs by default is to give the
application using it clear synchronisation points. For
change requests that means the interface function won't
return until the change has been commited as it will
call nl_wait_for_ack(). So if you disable it in NM and
run it on "old" kernels still using async netlink you
won't be sure when the change is actually being done so
this might break things if you rely on it.
I think providing a invalid message handler which returns
NL_OK if nlmsg_type is NLMSG_DONE or NLMSG_ERROR && err == 0
would be better if you need some kind of workaround. As
those messages are always last this should never cause
real troubles.
prev parent reply other threads:[~2007-10-25 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 0:58 Regression in current git - Network Manager fails (bisected) Joseph Fannin
2007-10-22 9:22 ` Denis V. Lunev
2007-10-22 15:57 ` Dan Williams
2007-10-23 12:11 ` Thomas Graf
2007-10-23 13:09 ` Denis V. Lunev
2007-10-23 13:38 ` Thomas Graf
2007-10-23 14:10 ` Dan Williams
2007-10-25 9:06 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025090609.GD8125@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=den@openvz.org \
--cc=den@sw.ru \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).