* [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics
@ 2007-10-26 1:59 Mitsuru Chinen
2007-10-30 5:03 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Mitsuru Chinen @ 2007-10-26 1:59 UTC (permalink / raw)
To: netdev; +Cc: David L Stevens
While displaying ICMP out-going statistics as Out<name> counters in
/proc/net/snmp, the memory location for ICMP in-coming statistics
was referred by mistake.
Acked-by: David L Stevens <dlstevens@us.ibm.com>
Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
---
net/ipv4/proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c
index fd16cb8..b7f7f8a 100644
--- a/net/ipv4/proc.c
+++ b/net/ipv4/proc.c
@@ -312,7 +312,7 @@ static void icmp_put(struct seq_file *seq)
for (i=0; icmpmibmap[i].name != NULL; i++)
seq_printf(seq, " %lu",
snmp_fold_field((void **) icmpmsg_statistics,
- icmpmibmap[i].index));
+ icmpmibmap[i].index | 0x100));
}
/*
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics
2007-10-26 1:59 [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics Mitsuru Chinen
@ 2007-10-30 5:03 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-30 5:03 UTC (permalink / raw)
To: mitch; +Cc: netdev, dlstevens
From: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Date: Fri, 26 Oct 2007 10:59:28 +0900
> While displaying ICMP out-going statistics as Out<name> counters in
> /proc/net/snmp, the memory location for ICMP in-coming statistics
> was referred by mistake.
>
> Acked-by: David L Stevens <dlstevens@us.ibm.com>
> Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Patch applied, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics
2007-10-29 20:54 Fw: " David Stevens
@ 2007-10-30 8:12 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-30 8:12 UTC (permalink / raw)
To: dlstevens; +Cc: davem, netdev
From: David Stevens <dlstevens@us.ibm.com>
Date: Mon, 29 Oct 2007 13:54:50 -0700
> Dave,
> I didn't see a response for this one... in case it fell through
> the
> cracks. Just want to make sure my bone-headed error doesn't hang
> around too long. :-)
It's in my tree now, never fear :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-30 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-26 1:59 [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics Mitsuru Chinen
2007-10-30 5:03 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-10-29 20:54 Fw: " David Stevens
2007-10-30 8:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).