[PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

[PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

[Mitsuru Chinen]

While displaying ICMP out-going statistics as Out<name> counters in
/proc/net/snmp, the memory location for ICMP in-coming statistics
was referred by mistake.

Acked-by: David L Stevens <dlstevens@us.ibm.com> 
Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
---
 net/ipv4/proc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c
index fd16cb8..b7f7f8a 100644
--- a/net/ipv4/proc.c
+++ b/net/ipv4/proc.c
@@ -312,7 +312,7 @@ static void icmp_put(struct seq_file *seq)
 	for (i=0; icmpmibmap[i].name != NULL; i++)
 		seq_printf(seq, " %lu",
 			snmp_fold_field((void **) icmpmsg_statistics,
-				icmpmibmap[i].index));
+				icmpmibmap[i].index | 0x100));
 }
 
 /*
-- 
1.5.3.4

Re: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

[David Miller]

From: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Date: Fri, 26 Oct 2007 10:59:28 +0900

> While displaying ICMP out-going statistics as Out<name> counters in
> /proc/net/snmp, the memory location for ICMP in-coming statistics
> was referred by mistake.
> 
> Acked-by: David L Stevens <dlstevens@us.ibm.com> 
> Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>

Patch applied, thank you!

Fw: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

[David Stevens]

Dave,
        I didn't see a response for this one... in case it fell through 
the
cracks. Just want to make sure my bone-headed error doesn't hang
around too long. :-)

                                                +-DLS

----- Forwarded by David Stevens/Beaverton/IBM on 10/29/2007 01:51 PM 
-----

Mitsuru Chinen <mitch@linux.vnet.ibm.com> 
Sent by: netdev-owner@vger.kernel.org
10/25/2007 06:59 PM

To
netdev@vger.kernel.org
cc
David Stevens/Beaverton/IBM@IBMUS
Subject
[PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP 
out-going statistics






While displaying ICMP out-going statistics as Out<name> counters in
/proc/net/snmp, the memory location for ICMP in-coming statistics
was referred by mistake.

Acked-by: David L Stevens <dlstevens@us.ibm.com> 
Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
---
 net/ipv4/proc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c
index fd16cb8..b7f7f8a 100644
--- a/net/ipv4/proc.c
+++ b/net/ipv4/proc.c
@@ -312,7 +312,7 @@ static void icmp_put(struct seq_file *seq)
                 for (i=0; icmpmibmap[i].name != NULL; i++)
                                 seq_printf(seq, " %lu",
                                                 snmp_fold_field((void **) 
icmpmsg_statistics,
- icmpmibmap[i].index));
+ icmpmibmap[i].index | 0x100));
 }
 
 /*
-- 
1.5.3.4

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

[David Miller]

From: David Stevens <dlstevens@us.ibm.com>
Date: Mon, 29 Oct 2007 13:54:50 -0700

> Dave,
>         I didn't see a response for this one... in case it fell through 
> the
> cracks. Just want to make sure my bone-headed error doesn't hang
> around too long. :-)

It's in my tree now, never fear :-)