From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] proc_fs.h redux Date: Sun, 28 Oct 2007 09:44:41 +0100 Message-ID: <20071028084441.GA24221@uranus.ravnborg.org> References: <20071027194758.GD9816@martell.zuzino.mipt.ru> <1193524804.26695.103.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexey Dobriyan , akpm@osdl.org, torvalds@osdl.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arch@vger.kernel.org To: Joe Perches Return-path: Received: from pasmtpb.tele.dk ([80.160.77.98]:46951 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbXJ1InG (ORCPT ); Sun, 28 Oct 2007 04:43:06 -0400 Content-Disposition: inline In-Reply-To: <1193524804.26695.103.camel@localhost> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > > As a general rule, I think it better to use includes > than use naked forward declarations. Quite the opposite - at least in the kernel source. The general rule is that a .h file shall include the .h files which contain declarations used by said .h files. But naked declarations as above is preferred over including a full header file. We see the full header dependency thing to blow off when inline function are used - which is more and more the case. In several cases we have converted inline functions to macros just to simplify the nightmare of header dependencies we have. Arnaldo have a nice script that generate a .ps file showing all the dependencies. He lately posted this URL: http://oops.ghostprotocols.net:81/acme/tcp.h.ps Sam